From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cksCR-0004Q7-07 for qemu-devel@nongnu.org; Mon, 06 Mar 2017 07:57:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cksCN-0007V0-Vc for qemu-devel@nongnu.org; Mon, 06 Mar 2017 07:57:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33658) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cksCN-0007Uv-PP for qemu-devel@nongnu.org; Mon, 06 Mar 2017 07:57:11 -0500 References: <20170305214633.19844-1-krzk@kernel.org> <20170306120948.GV2778@thinpad.lan.raisama.net> From: Paolo Bonzini Message-ID: Date: Mon, 6 Mar 2017 13:57:07 +0100 MIME-Version: 1.0 In-Reply-To: <20170306120948.GV2778@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qdev: Constify data pointed by few arguments and local variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , Krzysztof Kozlowski Cc: Kevin Wolf , Max Reitz , Markus Armbruster , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Alex Williamson , qemu-devel@nongnu.org On 06/03/2017 13:09, Eduardo Habkost wrote: >> >> -void qdev_prop_set_macaddr(DeviceState *dev, const char *name, uint8_t *value) >> +void qdev_prop_set_macaddr(DeviceState *dev, const char *name, >> + const uint8_t *value) > This one makes sense to me. Indeed. Krzysztof, you could extract this one and send it to qemu-trivial@nongnu.org. Thanks, Paolo