From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: mreitz@redhat.com, kwolf@redhat.com, fam@euphon.net, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf
Date: Wed, 6 Feb 2019 11:32:31 -0600 [thread overview]
Message-ID: <abf6dafa-da7d-4bf5-5a21-225c2809a038@redhat.com> (raw)
In-Reply-To: <20190206165342.219192-3-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On 2/6/19 10:53 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use new qemu_iovec_init_buf() instead of
> qemu_iovec_init_external( ... , 1), which simplifies the code.
Did you just do a manual search for candidate callers?
As you said in the cover letter, there are other files that can benefit
as well; are you planning on making v3 of the series longer?
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/io.c | 90 +++++++++++++-----------------------------------------
> 1 file changed, 21 insertions(+), 69 deletions(-)
But I'm loving the diffstat - it is definitely a nice change.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-06 17:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 16:53 [Qemu-devel] [PATCH v2 0/2] block: local qiov helper: part I Vladimir Sementsov-Ogievskiy
2019-02-06 16:53 ` [Qemu-devel] [PATCH v2 1/2] block: enhance QEMUIOVector structure Vladimir Sementsov-Ogievskiy
2019-02-06 17:25 ` Eric Blake
2019-02-06 17:50 ` Vladimir Sementsov-Ogievskiy
2019-02-06 16:53 ` [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf Vladimir Sementsov-Ogievskiy
2019-02-06 17:32 ` Eric Blake [this message]
2019-02-06 18:09 ` Vladimir Sementsov-Ogievskiy
2019-02-06 18:14 ` Eric Blake
2019-02-06 18:26 ` Vladimir Sementsov-Ogievskiy
2019-02-06 18:33 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abf6dafa-da7d-4bf5-5a21-225c2809a038@redhat.com \
--to=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).