From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evqEp-0001JY-7w for qemu-devel@nongnu.org; Tue, 13 Mar 2018 16:09:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evqEo-0006y5-9v for qemu-devel@nongnu.org; Tue, 13 Mar 2018 16:09:35 -0400 References: <20180313180320.339796-1-vsementsov@virtuozzo.com> <152096780751.39.15281812348627104231@71c20359a636> From: Eric Blake Message-ID: Date: Tue, 13 Mar 2018 15:09:02 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , "qemu-devel@nongnu.org" Cc: "kwolf@redhat.com" , "peter.maydell@linaro.org" , "famz@redhat.com" , "stefanha@redhat.com" , "qemu-block@nongnu.org" , "quintela@redhat.com" , "armbru@redhat.com" , "mreitz@redhat.com" , "lirans@il.ibm.com" , "amit.shah@redhat.com" , "pbonzini@redhat.com" , "jsnow@redhat.com" , "dgilbert@redhat.com" , Denis Lunev , Su Hang Paolo Bonzini On 03/13/2018 03:01 PM, Vladimir Sementsov-Ogievskiy wrote: > It looks like a bug in a recent commit to checkpatch. It don't support do { } while > > Checking PATCH 11/13: migration: add postcopy migration of dirty bitmaps... > ERROR: braces {} are necessary for all arms of this statement > #737: FILE: migration/block-dirty-bitmap.c:690: > + } while (!(s.flags & DIRTY_BITMAP_MIG_FLAG_EOS)); > [...] > Indeed, this is a regression in Su Hang's commit 2b9aef6f. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org