From: Florian Weimer <fweimer@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>, Cole Robinson <crobinso@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] memfd: fix configure test
Date: Tue, 28 Nov 2017 13:06:31 +0100 [thread overview]
Message-ID: <ac018dcf-7868-052e-7bdb-df0f3774f060@redhat.com> (raw)
In-Reply-To: <CAJ+F1CLzoyrtwG=iiB0_ocMGELrYY9-v_pm4AGaShFw3_CzHhQ@mail.gmail.com>
On 11/28/2017 12:42 PM, Marc-André Lureau wrote:
> Couldn't the declarations be put in sys/memfd.h like the man claimed
> it would be for > 1y?
We discussed it. It was a typo in the manual page. There never was a
<sys/memfd.h> header file:
https://marc.info/?l=linux-man&m=150988359906012&w=2
The UAPI header is called <linux/memfd.h>.
The downside of using a separate header is that you cannot determine,
using the preprocessor alone, whether the toolchain provides the
memfd_create function. If we put everything in <sys/mman.h>, you can
use “#ifdef MFD_CLOEXEC” to see if the definitions and declarations are
there.
Thanks,
Florian
prev parent reply other threads:[~2017-11-28 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 11:32 [Qemu-devel] [PATCH] memfd: fix configure test Paolo Bonzini
2017-11-28 11:42 ` Marc-André Lureau
2017-11-28 11:49 ` Paolo Bonzini
2017-11-28 11:57 ` Peter Maydell
2017-11-28 12:06 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac018dcf-7868-052e-7bdb-df0f3774f060@redhat.com \
--to=fweimer@redhat.com \
--cc=crobinso@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).