From: Ninad Palsule <ninad@linux.vnet.ibm.com>
To: Stefan Berger <stefanb@linux.ibm.com>,
Ninad Palsule <ninad@linux.ibm.com>,
qemu-devel@nongnu.org
Cc: joel@jms.id.au, andrew@aj.id.au, clg@kaod.org
Subject: Re: [PATCH 2/3] Add support for TPM devices over I2C bus
Date: Wed, 22 Mar 2023 11:56:34 -0500 [thread overview]
Message-ID: <ac0ba35a-9122-4af6-7fa5-e2bafe95e805@linux.vnet.ibm.com> (raw)
In-Reply-To: <03fda37a-39eb-2166-d883-084759684f0c@linux.ibm.com>
On 3/22/23 6:24 AM, Stefan Berger wrote:
>
>
> On 3/22/23 07:18, Ninad Palsule wrote:
>>
>> On 3/21/23 6:54 PM, Stefan Berger wrote:
>
>
>>>> @@ -703,6 +726,7 @@ static void tpm_tis_mmio_write(void *opaque,
>>>> hwaddr addr,
>>>> break;
>>>> case TPM_TIS_REG_DATA_FIFO:
>>>> case TPM_TIS_REG_DATA_XFIFO ... TPM_TIS_REG_DATA_XFIFO_END:
>>>> +
>>>
>>> you can remove this one
>> Sorry, I am not clear what you are asking me to remove.
>
> You added an empty line here.
>
> Stefan
Ah, Fixed it.
Thank you for the review.
Ninad Palsule
next prev parent reply other threads:[~2023-03-22 16:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 5:29 [PATCH 0/3] Add support for TPM devices over I2C bus Ninad Palsule
2023-03-21 5:29 ` [PATCH 1/3] " Ninad Palsule
2023-03-21 23:35 ` Stefan Berger
2023-03-22 11:13 ` Ninad Palsule
2023-03-21 5:30 ` [PATCH 2/3] " Ninad Palsule
2023-03-21 23:54 ` Stefan Berger
2023-03-22 11:18 ` Ninad Palsule
2023-03-22 11:24 ` Stefan Berger
2023-03-22 16:56 ` Ninad Palsule [this message]
2023-03-22 12:05 ` Stefan Berger
2023-03-22 16:58 ` Ninad Palsule
2023-03-21 5:30 ` [PATCH 3/3] " Ninad Palsule
2023-03-22 1:10 ` Stefan Berger
2023-03-22 11:26 ` Ninad Palsule
2023-03-22 1:30 ` Stefan Berger
2023-03-22 11:28 ` Ninad Palsule
2023-03-22 11:50 ` Stefan Berger
2023-03-22 13:04 ` Stefan Berger
2023-03-23 0:43 ` Ninad Palsule
2023-03-22 17:01 ` Ninad Palsule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac0ba35a-9122-4af6-7fa5-e2bafe95e805@linux.vnet.ibm.com \
--to=ninad@linux.vnet.ibm.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=ninad@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).