From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1botdZ-0001Xp-4W for qemu-devel@nongnu.org; Tue, 27 Sep 2016 10:45:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1botdV-00041P-1F for qemu-devel@nongnu.org; Tue, 27 Sep 2016 10:45:37 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:45302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1botdU-0003zs-Os for qemu-devel@nongnu.org; Tue, 27 Sep 2016 10:45:32 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8REgrcu056540 for ; Tue, 27 Sep 2016 10:45:31 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 25qsad4yhv-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 27 Sep 2016 10:45:31 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 27 Sep 2016 15:45:28 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9A3D417D805A for ; Tue, 27 Sep 2016 15:47:27 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8REjPlE1835308 for ; Tue, 27 Sep 2016 14:45:25 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u8REjPaN001019 for ; Tue, 27 Sep 2016 10:45:25 -0400 References: <1474463939-12223-1-git-send-email-pbonzini@redhat.com> <1df4f6a2-f4ed-8826-823b-4a879368ccb8@redhat.com> From: Christian Borntraeger Date: Tue, 27 Sep 2016 16:45:24 +0200 MIME-Version: 1.0 In-Reply-To: <1df4f6a2-f4ed-8826-823b-4a879368ccb8@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, mst@redhat.com, famz@redhat.com On 09/21/2016 06:43 PM, Paolo Bonzini wrote: > > > On 21/09/2016 16:01, Christian Borntraeger wrote: >> On 09/21/2016 03:18 PM, Paolo Bonzini wrote: >>> This series started as an attempt to always use the dataplane path >>> for virtio-blk and virtio-scsi when ioeventfd is active. The aim >>> was three-fold: >>> >>> 1) to add more coverage for dataplane >>> >>> 2) to remove virtio_add_queue_aio >>> >>> 3) to simplify the dataplane start/stop code >>> >>> It achieves the first two objectives, and while it doesn't quite >>> achieve the third it does cleanup the generic ioeventfd code in >>> virtio-bus more than I expected. In particular, it reduces the set >>> of callbacks that transports must implement, and it removes the ugly >>> case where ioeventfd is started with generic callbacks and then moved >>> to the dataplane callbacks. It also enables some simplification of the >>> functions that deal with host notifiers. >>> >>> I've tested it with virtio-blk, virtio-scsi and vhost-net. >>> >>> Patches 1 and 2 are simplifications that are too nice to leave >>> them for later in the series. >>> >>> Patch 3 moves some of the ioeventfd code from virtio-bus.c to >>> virtio.c. At this point the transition is a bit half-assed, but >>> this changes as soon as we remove the generic->dataplane >>> handler transition. >>> >>> Patches 4 to 6 do exactly that, and then the spring cleaning >>> begins, lasting for the whole second half of the series. >>> >>> Opinions, reviews and bug reports? >> >> is there a branch? > > ioeventfd-virtio in my github repo. Triggering qemu-system-s390x: /home/cborntra/REPOS/qemu/hw/block/virtio-blk.c:771: virtio_blk_set_status: Assertion `!s->dataplane_started' failed. Is this based on the old version that still had this bug?