Re: [PATCH] .gitlab-ci.d/windows.yml: Disable the qtests in the MSYS2 job

[Thomas Huth <thuth@redhat.com>]

On 16/08/2024 18.34, Philippe Mathieu-Daudé wrote:
> On 16/8/24 17:37, Thomas Huth wrote:
>> The qtests are broken since a while in the MSYS2 job in the gitlab-CI,
>> likely due to some changes in the MSYS2 environment. So far nobody has
>> neither a clue what's going wrong here, nor an idea how to fix this
>> (in fact most QEMU developers even don't have a Windows environment
>> available for properly analyzing this problem), so let's disable the
>> qtests here again to get at least the test coverage for the compilation
>> and unit tests back to the CI.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   .gitlab-ci.d/windows.yml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml
>> index a83f23a786..9f3112f010 100644
>> --- a/.gitlab-ci.d/windows.yml
>> +++ b/.gitlab-ci.d/windows.yml
>> @@ -23,6 +23,8 @@ msys2-64bit:
>>       # for this job, because otherwise the build could not complete within
>>       # the project timeout.
>>       CONFIGURE_ARGS:  --target-list=sparc-softmmu 
>> --without-default-devices -Ddebug=false -Doptimization=0
>> +    # The qtests are broken in the msys2 job on gitlab, so disable them:
>> +    TEST_ARGS: --no-suite qtest
> 
> Then building system emulation is pointless, isn't it?

We're still running the unit tests and some others.

> Could we at least test the block tools? qemu-img seems to work:
> 
> # ./qemu-img.exe --help
> qemu-img version 9.0.92 (v9.1.0-rc2)
> Copyright (c) 2003-2024 Fabrice Bellard and the QEMU Project developers
> usage: qemu-img [standard options] command [command options]
> QEMU disk image utility
> 
>      '-h', '--help'       display this help and exit
>      '-V', '--version'    output version information and exit
> ...
> 
> It doesn't work currently:
...
> Administrator@FOOBAR UCRT64 /c/Users/Administrator/qemu/build
> # make check-block
> make: *** No rule to make target 'check-block'.  Stop.

check-block never worked on Windows as far as I know, it's disabled in the 
meson.build there:

if not have_tools or host_os == 'windows'
   subdir_done()
endif

  Thomas