From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Jason Wang <jasowang@redhat.com>,
qemu-arm@nongnu.org, Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH v2 2/2] hw/net: Move MV88W8618 network device out of hw/arm/ directory
Date: Fri, 17 Dec 2021 14:25:46 -0800 [thread overview]
Message-ID: <ac288aa7-b78a-d564-329a-07267f2d4cc3@linaro.org> (raw)
In-Reply-To: <20211216125647.805544-3-f4bug@amsat.org>
On 12/16/21 4:56 AM, Philippe Mathieu-Daudé wrote:
> +softmmu_ss.add(when: 'CONFIG_MUSICPAL', if_true: files('mv88w8618_eth.c'))
So... there's currently a MARVELL_88W8618 define for the audio component of the same chip.
Should we re-use that here?
Otherwise,
Acked-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-12-17 22:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 12:56 [PATCH v2 0/2] hw/net: Move MV88W8618 network device out of hw/arm/ directory Philippe Mathieu-Daudé
2021-12-16 12:56 ` [PATCH v2 1/2] hw/arm/musicpal: Fix coding style of code related to MV88W8618 device Philippe Mathieu-Daudé
2021-12-17 22:19 ` Richard Henderson
2021-12-16 12:56 ` [PATCH v2 2/2] hw/net: Move MV88W8618 network device out of hw/arm/ directory Philippe Mathieu-Daudé
2021-12-17 22:25 ` Richard Henderson [this message]
2021-12-17 23:21 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac288aa7-b78a-d564-329a-07267f2d4cc3@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=jan.kiszka@web.de \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).