From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Li Qiang <liq3ea@gmail.com>,
peter.maydell@linaro.org, pbonzini@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Rom: change Rom's 'isrom' to bool type
Date: Tue, 9 Oct 2018 10:22:05 +0200 [thread overview]
Message-ID: <ac397e6c-6302-0aad-c0da-a878be8e5463@redhat.com> (raw)
In-Reply-To: <1539068913-3796-1-git-send-email-liq3ea@gmail.com>
On 09/10/2018 09:08, Li Qiang wrote:
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/core/loader.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/loader.c b/hw/core/loader.c
> index aa0b3fc867..910f9a97a9 100644
> --- a/hw/core/loader.c
> +++ b/hw/core/loader.c
> @@ -837,7 +837,7 @@ struct Rom {
> uint8_t *data;
> MemoryRegion *mr;
> AddressSpace *as;
> - int isrom;
> + bool isrom;
> char *fw_dir;
> char *fw_file;
>
>
prev parent reply other threads:[~2018-10-09 8:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 7:08 [Qemu-devel] [PATCH] Rom: change Rom's 'isrom' to bool type Li Qiang
2018-10-09 8:22 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac397e6c-6302-0aad-c0da-a878be8e5463@redhat.com \
--to=philmd@redhat.com \
--cc=liq3ea@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).