From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tests/libqtest: Remove unused global_qtest-related wrapper functions
Date: Fri, 10 May 2019 10:24:45 -0500 [thread overview]
Message-ID: <ac4a7ace-813d-31a8-9aae-1b5523988de8@redhat.com> (raw)
In-Reply-To: <20190510052239.21947-1-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
On 5/10/19 12:22 AM, Thomas Huth wrote:
> A bunch of the wrapper functions that use global_qtest are not used
> anymore. Remove them to avoid that they are used in new code again.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/libqtest.c | 11 +----
> tests/libqtest.h | 108 -----------------------------------------------
> 2 files changed, 1 insertion(+), 118 deletions(-)
Nice!
Reviewed-by: Eric Blake <eblake@redhat.com>
> -/**
> - * qtest_irq_intercept_out:
> - * @string: QOM path of a device.
> - *
> - * Associate qtest irqs with the GPIO-out pins of the device
> - * whose path is specified by @string.
> - */
> -static inline void irq_intercept_out(const char *string)
Fixes a copy-and-paste misdocumentation bug while at it :)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-10 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 5:22 [Qemu-devel] [PATCH] tests/libqtest: Remove unused global_qtest-related wrapper functions Thomas Huth
2019-05-10 15:24 ` Eric Blake [this message]
2019-05-15 10:27 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac4a7ace-813d-31a8-9aae-1b5523988de8@redhat.com \
--to=eblake@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).