From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50518C433E0 for ; Mon, 13 Jul 2020 19:33:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1678A2076D for ; Mon, 13 Jul 2020 19:33:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YdxPp2O7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1678A2076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jv4CX-0007ap-De for qemu-devel@archiver.kernel.org; Mon, 13 Jul 2020 15:33:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jv4BD-0006EJ-Rb for qemu-devel@nongnu.org; Mon, 13 Jul 2020 15:31:59 -0400 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:40304) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jv4BC-0007m5-55 for qemu-devel@nongnu.org; Mon, 13 Jul 2020 15:31:59 -0400 Received: by mail-pg1-x541.google.com with SMTP id e18so6468876pgn.7 for ; Mon, 13 Jul 2020 12:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=w6i5hVoOyHjvxFLItb4ie5QHkJsy6FaHB02eCSQQRPs=; b=YdxPp2O7b+Mx4Foa1E44yZdvXcpnXtXsEvPX3i+X4v6H8ZYlhOhdvTZS1zlDj4jE41 hS9Gu409fMr8vcYgIvI3XpP0k2gtLXbU3wwF2QErCmJ7Ll6ZCQOgIQ/Xbf5M5BWudC6X albk33ieU5UMKeNxCT6fd3Q0i8V7BR3vH1gO+xLySZpfEAcJ2TlJ+YySDXSiclBdYe3S hee1gMD+9l2ukLAKS64lxAXpcdaN62lPUTf1Te5vLwqvsJJf2WtxZVSI0YcbyXpO5lGx wylv8b++AqngSrTegVDyvudhLNmEVkcoMUOS/ds3B3dzx4TmQ8GifqOfxLvO0tlpKWpq dlZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w6i5hVoOyHjvxFLItb4ie5QHkJsy6FaHB02eCSQQRPs=; b=KSS8GZJodlP0oWP7aLmVfxORoU6fWLz1u2rOsr2EJDpTyNRYMZEuS0NK3WbYb/PDzz 1L2wvBIIag5/Uhr6ZdtM3Wmt6f3vyZ3wNMaO0p2uM4w1aVm3KTNYgDewu/TjKCQhGQdx zRVYqn1XRTd5tWyuSMez3M4+HbhKWOczHkOSlgi3rDlAfhh2v+bfd4gHQ9TK7XtmuDal YqVjmvJXUTKjJM4otX5j6q24wFPHkePg7mq6ynY3GhHu/x7hcIqd6sqJzpTnRh5tB4bo FoUEep36tTfWonplQII1juxNyxOFgFZrxiw6Jxf/imiFspDnIIHfpNzrp7xJP1S8qscx hiig== X-Gm-Message-State: AOAM531fDZnD4aJqbhu9T5SmbUN3TCvYjbhn87RkgxYFCl3zOjznOX9K q3t/e96Xx2TTP1FHkO+IJFx4MQ== X-Google-Smtp-Source: ABdhPJwJxskLokCB1qPk0VreSqTnnU92Olv/QG79QSThJdJM/9f9U16PBVpKPFKUthocJj/1boacYQ== X-Received: by 2002:a62:15c3:: with SMTP id 186mr1302355pfv.30.1594668716621; Mon, 13 Jul 2020 12:31:56 -0700 (PDT) Received: from [192.168.1.11] (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id w4sm15278787pfd.39.2020.07.13.12.31.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2020 12:31:56 -0700 (PDT) Subject: Re: [RFC PATCH 6/8] fpu/softfloat: define operation for bfloat16 To: LIU Zhiwei , qemu-devel@nongnu.org References: <20200712234521.3972-1-zhiwei_liu@c-sky.com> <20200712234521.3972-7-zhiwei_liu@c-sky.com> From: Richard Henderson Message-ID: Date: Mon, 13 Jul 2020 12:31:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200712234521.3972-7-zhiwei_liu@c-sky.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::541; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x541.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wenmeng_zhang@c-sky.com, alex.bennee@linaro.org, wxy194768@alibaba-inc.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/12/20 4:45 PM, LIU Zhiwei wrote: > @@ -3039,7 +3143,7 @@ static FloatParts scalbn_decomposed > return return_nan(a, s); > } > if (a.cls == float_class_normal) { > - /* The largest float type (even though not supported by FloatParts) > + /* The largest float type (even though nt supported by FloatParts) Oops. Otherwise, Reviewed-by: Richard Henderson r~