qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: edgar.iglesias@xilinx.com, f4bug@amsat.org
Subject: Re: [PATCH v2 00/12] target/microblaze improvements
Date: Thu, 3 Sep 2020 14:24:30 +0200	[thread overview]
Message-ID: <ac534848-6d8c-d54a-6597-047bb8e3cdc7@redhat.com> (raw)
In-Reply-To: <20200903072650.1360454-1-richard.henderson@linaro.org>

On 03/09/2020 09.26, Richard Henderson wrote:
> Version 2 includes fixes for iflags that could cause lockups.
> 
> It seems it was easier to do so with icount=7, which is what we do during
> the replay acceptance tests.  This causes TBs to contain no more than 7
> insns, and often less to make up for an incomplete count elsewhere.
> Which stressed the iflags bits around delay slots and imm in ways that
> pure single-step doesn't.
> 
> In addition, cpu vmstate is filled in and interrupt logging is tidied.

Thanks, this fixes the failing acceptance test in the Gitlab-CI for me:

 https://gitlab.com/huth/qemu/-/pipelines/185245009

Tested-by: Thomas Huth <thuth@redhat.com>



      parent reply	other threads:[~2020-09-03 12:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03  7:26 [PATCH v2 00/12] target/microblaze improvements Richard Henderson
2020-09-03  7:26 ` [PATCH v2 01/12] target/microblaze: Collected fixes for env->iflags Richard Henderson
2020-09-03  7:26 ` [PATCH v2 02/12] target/microblaze: Renumber D_FLAG Richard Henderson
2020-09-03  7:26 ` [PATCH v2 03/12] target/microblaze: Cleanup mb_cpu_do_interrupt Richard Henderson
2020-09-03  7:26 ` [PATCH v2 04/12] target/microblaze: Rename mmu structs Richard Henderson
2020-09-04 12:10   ` Edgar E. Iglesias
2020-09-04 12:43   ` Philippe Mathieu-Daudé
2020-09-03  7:26 ` [PATCH v2 05/12] target/microblaze: Fill in VMStateDescription for cpu Richard Henderson
2020-09-04 12:20   ` Edgar E. Iglesias
2020-09-04 15:25     ` Richard Henderson
2020-09-04 15:31       ` Edgar Iglesias
2020-09-03  7:26 ` [PATCH v2 06/12] target/microblaze: Rename DISAS_UPDATE to DISAS_EXIT Richard Henderson
2020-09-04 12:44   ` Philippe Mathieu-Daudé
2020-09-03  7:26 ` [PATCH v2 07/12] target/microblaze: Introduce DISAS_EXIT_NEXT, DISAS_EXIT_JUMP Richard Henderson
2020-09-03  7:26 ` [PATCH v2 08/12] target/microblaze: Replace cpustate_changed with DISAS_EXIT_NEXT Richard Henderson
2020-09-03  7:26 ` [PATCH v2 09/12] target/microblaze: Handle DISAS_EXIT_NEXT in delay slot Richard Henderson
2020-09-03  7:26 ` [PATCH v2 10/12] target/microblaze: Force rtid, rted, rtbd to exit Richard Henderson
2020-09-03  7:26 ` [PATCH v2 11/12] target/microblaze: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2020-09-03  7:26 ` [PATCH v2 12/12] target/microblaze: Diagnose invalid insns in delay slots Richard Henderson
2020-09-04 12:27   ` Edgar E. Iglesias
2020-09-03 12:24 ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac534848-6d8c-d54a-6597-047bb8e3cdc7@redhat.com \
    --to=thuth@redhat.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).