From: Eric Blake <eblake@redhat.com>
To: Chad Joan <chadjoan@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Fam Zheng <famz@redhat.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Laszlo Ersek <lersek@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems.
Date: Mon, 20 Feb 2017 21:02:13 -0600 [thread overview]
Message-ID: <ac569867-6629-7b56-0bf1-85f15b52f143@redhat.com> (raw)
In-Reply-To: <CABHMSTUS4Oi5WZt0NcYaOnX9_u8zQeu=CupLVX2LjvD+mTYATg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3335 bytes --]
On 02/19/2017 01:02 AM, Chad Joan wrote:
> development work. There are no user accounts, just root. I have tried to
> avoid putting any personal information on it. If I am on it, then I'm
> editing files in /etc or installing system-wide software. I'm realizing
> that I might have to change this a bit due to the WIP nature of the
> hardened-musl profile: ultimately I *am* doing development work on it, and
> that kind of snuck up on me. If I give myself a user account, then
> authoring patches with git (and using send-email) becomes somewhat more
> practical (putting smtp login information onto the machine still bugs me).
You don't have to store your SMTP passwords; git is smart enough to ask
you interactively if you (intentionally) omit the passwords from
.gitconfig. But I agree that even storing your SMTP address and
username in configs can be a bit hairier than you want on some boxes.
> Still, I can't imagine I'm the only person who runs into this kind of thing
> and wants to write quick patches on an impersonal machine.
There's always the option to float the patches back to a personal
machine before posting to the list (yes, it requires more work on your
end, but if it serves as a nice manual wall between your internal and
external machines, it may well be worth the discipline).
>
>
>> [...]
>>
>> But nothing requires you to set up a certificate to submit a patch. I'm
>> not sure which piece of the documentation got you steered in that
>> direction, but gpg signing of patches is only required of maintainers,
>> not contributors (or maybe you're hinting at the extra effort required
>> to set up gmail as a valid 'git send-email' target, to which I have no
>> experience, but which starts to leave the realm of qemu-specific
>> instructions into something where it would be better to link to a good
>> git setup tutorial, if one exists).
>>
>>
> I think this is just language ambiguity and confirmation bias doing their
> thing. Usually when I read "you have to sign this" in an OSS context, I
> think of cryptographic signing. I haven't encountered the requirement for
> non-cryptographic signing before. Language is arbitrary and we all have
> different experiences and backgrounds.
Is it sufficient to just give the example of 'git commit -s' being the
trick to automatically adding the necessary Signed-off-by: line? (Of
course, automating the process like that, without actually reading
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297
to understand what it means and that you actually comply, is risky)
>
> This is one of the reasons why I suggest a simple example: it would be both
> very concise and unambiguous. If there are no signing steps in the example
> then you don't even need to spend words telling the reader that
> cryptographic signing is unnecessary. It'll be implied.
>
> Thankfully, this is a separate concern from the 'git send-email' thing.
'git send-email -s' can also add Signed-off-by: lines, if you didn't add
them earlier (but only if you use send-email, rather than attachments) :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-02-21 3:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 16:30 [Qemu-devel] Fix build break during configuration on musl-libc based Linux systems Chad Joan
2017-02-16 16:58 ` Paolo Bonzini
2017-02-16 17:23 ` Laszlo Ersek
2017-02-16 17:47 ` Chad Joan
2017-02-17 6:43 ` Fam Zheng
2017-02-17 9:23 ` Laszlo Ersek
2017-02-17 10:11 ` Fam Zheng
2017-02-17 9:28 ` Peter Maydell
2017-02-17 15:34 ` Eric Blake
2017-02-17 16:54 ` Chad Joan
2017-02-17 16:56 ` Peter Maydell
2017-02-17 16:57 ` Paolo Bonzini
2017-02-17 17:07 ` Chad Joan
2017-02-17 17:15 ` Peter Maydell
2017-02-19 7:22 ` Chad Joan
2017-02-19 12:12 ` Peter Maydell
2017-02-21 2:53 ` Eric Blake
2017-02-17 17:17 ` Eric Blake
2017-02-19 7:02 ` Chad Joan
2017-02-21 3:02 ` Eric Blake [this message]
2017-02-21 9:41 ` Markus Armbruster
2017-02-21 9:58 ` Peter Maydell
2017-02-17 18:13 ` John Snow
2017-02-17 8:45 ` Paolo Bonzini
2017-02-17 8:56 ` Paolo Bonzini
2017-02-17 9:17 ` Laszlo Ersek
2017-02-17 11:11 ` Paolo Bonzini
2017-02-17 11:43 ` Chad Joan
2017-02-17 10:18 ` Peter Maydell
2017-02-17 11:20 ` Paolo Bonzini
2017-02-17 16:57 ` Peter Maydell
2017-04-06 18:15 ` Rainer Müller
2017-04-06 18:36 ` Peter Maydell
2017-06-02 13:58 ` Peter Maydell
2017-02-16 16:59 ` Eric Blake
2017-02-16 17:05 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac569867-6629-7b56-0bf1-85f15b52f143@redhat.com \
--to=eblake@redhat.com \
--cc=chadjoan@gmail.com \
--cc=famz@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).