From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Jason Wang" <jasowang@redhat.com>,
"Aleksandar Rikalo" <arikalo@gmail.com>,
"Anton Johansson" <anjo@rev.ng>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Sven Schnelle" <svens@stackframe.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
qemu-arm@nongnu.org, "Aurelien Jarno" <aurelien@aurel32.net>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Paul Burton" <paulburton@kernel.org>
Subject: Re: [PATCH 09/13] exec/memory_ldst_phys: Introduce ld/st_endian_phys() API
Date: Tue, 1 Oct 2024 09:54:15 -0700 [thread overview]
Message-ID: <ac7bde34-8c7a-4841-b8c2-94eb1bb1c724@linaro.org> (raw)
In-Reply-To: <20240930073450.33195-10-philmd@linaro.org>
On 9/30/24 00:34, Philippe Mathieu-Daudé wrote:
> Introduce the ld/st_endian_phys() API, which takes an extra
> boolean argument to dispatch to ld/st_{be,le}_phys() methods.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> TODO: Update docstring regexp
> ---
> include/exec/memory_ldst_phys.h.inc | 66 +++++++++++++++++++++++++++++
> 1 file changed, 66 insertions(+)
>
> diff --git a/include/exec/memory_ldst_phys.h.inc b/include/exec/memory_ldst_phys.h.inc
> index ecd678610d..8ea162b40d 100644
> --- a/include/exec/memory_ldst_phys.h.inc
> +++ b/include/exec/memory_ldst_phys.h.inc
> @@ -74,6 +74,16 @@ static inline uint16_t glue(lduw_be_phys, SUFFIX)(ARG1_DECL, hwaddr addr)
> MEMTXATTRS_UNSPECIFIED, NULL);
> }
>
> +static inline uint16_t glue(lduw_endian_phys, SUFFIX)(bool big_endian,
> + ARG1_DECL, hwaddr addr)
> +{
> + return big_endian
> + ? glue(address_space_lduw_le, SUFFIX)(ARG1, addr,
> + MEMTXATTRS_UNSPECIFIED, NULL)
> + : glue(address_space_lduw_be, SUFFIX)(ARG1, addr,
> + MEMTXATTRS_UNSPECIFIED, NULL);
> +}
> +
> static inline uint32_t glue(ldl_le_phys, SUFFIX)(ARG1_DECL, hwaddr addr)
> {
> return glue(address_space_ldl_le, SUFFIX)(ARG1, addr,
> @@ -86,6 +96,16 @@ static inline uint32_t glue(ldl_be_phys, SUFFIX)(ARG1_DECL, hwaddr addr)
> MEMTXATTRS_UNSPECIFIED, NULL);
> }
>
> +static inline uint32_t glue(ldl_endian_phys, SUFFIX)(bool big_endian,
> + ARG1_DECL, hwaddr addr)
> +{
> + return big_endian
> + ? glue(address_space_ldl_le, SUFFIX)(ARG1, addr,
> + MEMTXATTRS_UNSPECIFIED, NULL)
> + : glue(address_space_ldl_be, SUFFIX)(ARG1, addr,
> + MEMTXATTRS_UNSPECIFIED, NULL);
> +}
> +
> static inline uint64_t glue(ldq_le_phys, SUFFIX)(ARG1_DECL, hwaddr addr)
> {
> return glue(address_space_ldq_le, SUFFIX)(ARG1, addr,
> @@ -98,6 +118,16 @@ static inline uint64_t glue(ldq_be_phys, SUFFIX)(ARG1_DECL, hwaddr addr)
> MEMTXATTRS_UNSPECIFIED, NULL);
> }
>
> +static inline uint32_t glue(ldq_endian_phys, SUFFIX)(bool big_endian,
> + ARG1_DECL, hwaddr addr)
> +{
> + return big_endian
> + ? glue(address_space_ldq_le, SUFFIX)(ARG1, addr,
> + MEMTXATTRS_UNSPECIFIED, NULL)
> + : glue(address_space_ldq_be, SUFFIX)(ARG1, addr,
> + MEMTXATTRS_UNSPECIFIED, NULL);
> +}
> +
> static inline void glue(stb_phys, SUFFIX)(ARG1_DECL, hwaddr addr, uint8_t val)
> {
> glue(address_space_stb, SUFFIX)(ARG1, addr, val,
> @@ -116,6 +146,18 @@ static inline void glue(stw_be_phys, SUFFIX)(ARG1_DECL, hwaddr addr, uint16_t va
> MEMTXATTRS_UNSPECIFIED, NULL);
> }
>
> +static inline void glue(stw_endian_phys, SUFFIX)(bool big_endian, ARG1_DECL,
> + hwaddr addr, uint16_t val)
> +{
> + if (big_endian) {
> + glue(address_space_stw_be, SUFFIX)(ARG1, addr, val,
> + MEMTXATTRS_UNSPECIFIED, NULL);
> + } else {
> + glue(address_space_stw_le, SUFFIX)(ARG1, addr, val,
> + MEMTXATTRS_UNSPECIFIED, NULL);
> + }
> +}
> +
> static inline void glue(stl_le_phys, SUFFIX)(ARG1_DECL, hwaddr addr, uint32_t val)
> {
> glue(address_space_stl_le, SUFFIX)(ARG1, addr, val,
> @@ -128,6 +170,18 @@ static inline void glue(stl_be_phys, SUFFIX)(ARG1_DECL, hwaddr addr, uint32_t va
> MEMTXATTRS_UNSPECIFIED, NULL);
> }
>
> +static inline void glue(stl_endian_phys, SUFFIX)(bool big_endian, ARG1_DECL,
> + hwaddr addr, uint32_t val)
> +{
> + if (big_endian) {
> + glue(address_space_stl_be, SUFFIX)(ARG1, addr, val,
> + MEMTXATTRS_UNSPECIFIED, NULL);
> + } else {
> + glue(address_space_stl_le, SUFFIX)(ARG1, addr, val,
> + MEMTXATTRS_UNSPECIFIED, NULL);
> + }
> +}
> +
> static inline void glue(stq_le_phys, SUFFIX)(ARG1_DECL, hwaddr addr, uint64_t val)
> {
> glue(address_space_stq_le, SUFFIX)(ARG1, addr, val,
> @@ -139,6 +193,18 @@ static inline void glue(stq_be_phys, SUFFIX)(ARG1_DECL, hwaddr addr, uint64_t va
> glue(address_space_stq_be, SUFFIX)(ARG1, addr, val,
> MEMTXATTRS_UNSPECIFIED, NULL);
> }
> +
> +static inline void glue(stq_endian_phys, SUFFIX)(bool big_endian, ARG1_DECL,
> + hwaddr addr, uint64_t val)
> +{
> + if (big_endian) {
> + glue(address_space_stq_be, SUFFIX)(ARG1, addr, val,
> + MEMTXATTRS_UNSPECIFIED, NULL);
> + } else {
> + glue(address_space_stq_le, SUFFIX)(ARG1, addr, val,
> + MEMTXATTRS_UNSPECIFIED, NULL);
> + }
> +}
> #endif
>
> #undef ARG1_DECL
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
next prev parent reply other threads:[~2024-10-01 16:55 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 7:34 [PATCH 00/13] hw: Add ld/st_endian() APIs Philippe Mathieu-Daudé
2024-09-30 7:34 ` [PATCH 01/13] qemu/bswap: Introduce ld/st_endian_p() API Philippe Mathieu-Daudé
2024-10-01 16:45 ` Pierrick Bouvier
2024-10-03 20:50 ` Philippe Mathieu-Daudé
2024-10-03 21:28 ` Richard Henderson
2024-10-03 21:34 ` Philippe Mathieu-Daudé
2024-10-03 21:37 ` Richard Henderson
2024-10-03 21:46 ` Philippe Mathieu-Daudé
2024-09-30 7:34 ` [PATCH 02/13] hw/virtio/virtio-access: Use the " Philippe Mathieu-Daudé
2024-10-01 16:46 ` Pierrick Bouvier
2024-09-30 7:34 ` [PATCH 03/13] target/arm/ptw: " Philippe Mathieu-Daudé
2024-10-01 16:46 ` Pierrick Bouvier
2024-09-30 7:34 ` [PATCH 04/13] hw/mips: Pass BlCpuCfg argument to bootloader API Philippe Mathieu-Daudé
2024-10-01 16:49 ` Pierrick Bouvier
2024-09-30 7:34 ` [PATCH 05/13] hw/mips: Add cpu_is_bigendian field to BlCpuCfg structure Philippe Mathieu-Daudé
2024-10-01 16:50 ` Pierrick Bouvier
2024-09-30 7:34 ` [PATCH 06/13] tests/tcg/plugins: Use the ld/st_endian_p() API Philippe Mathieu-Daudé
2024-10-01 16:50 ` Pierrick Bouvier
2024-10-02 12:18 ` Alex Bennée
2024-09-30 7:34 ` [PATCH 07/13] hw/xtensa/xtfpga: Remove TARGET_BIG_ENDIAN #ifdef'ry Philippe Mathieu-Daudé
2024-09-30 14:28 ` Thomas Huth
2024-10-01 16:51 ` Pierrick Bouvier
2024-10-03 21:35 ` Richard Henderson
2024-10-10 18:08 ` Philippe Mathieu-Daudé
2024-09-30 7:34 ` [PATCH 08/13] hw/xtensa/xtfpga: Replace memcpy()+tswap32() by stl_endian_p() Philippe Mathieu-Daudé
2024-09-30 14:32 ` Thomas Huth
2024-10-03 16:02 ` Philippe Mathieu-Daudé
2024-10-03 16:04 ` Pierrick Bouvier
2024-10-03 20:48 ` Philippe Mathieu-Daudé
2024-10-03 21:31 ` Pierrick Bouvier
2024-10-03 21:34 ` Pierrick Bouvier
2024-10-03 21:40 ` Philippe Mathieu-Daudé
2024-10-04 6:44 ` Thomas Huth
2024-10-04 14:08 ` Richard Henderson
2024-09-30 7:34 ` [PATCH 09/13] exec/memory_ldst_phys: Introduce ld/st_endian_phys() API Philippe Mathieu-Daudé
2024-10-01 16:54 ` Pierrick Bouvier [this message]
2024-10-03 21:39 ` Richard Henderson
2024-10-03 21:47 ` Richard Henderson
2024-09-30 7:34 ` [PATCH 10/13] hw/virtio/virtio-access: Use " Philippe Mathieu-Daudé
2024-10-01 16:54 ` Pierrick Bouvier
2024-09-30 7:34 ` [PATCH 11/13] hw/pci/pci_device: Add PCI_DMA_DEFINE_LDST_END() macro Philippe Mathieu-Daudé
2024-10-01 16:56 ` Pierrick Bouvier
2024-09-30 7:34 ` [PATCH 12/13] hw/pci/pci_device: Introduce ld/st_endian_pci_dma() API Philippe Mathieu-Daudé
2024-10-01 16:57 ` Pierrick Bouvier
2024-10-03 22:04 ` Richard Henderson
2024-09-30 7:34 ` [PATCH 13/13] hw/net/tulip: Use " Philippe Mathieu-Daudé
2024-10-01 16:57 ` Pierrick Bouvier
2024-10-03 22:10 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac7bde34-8c7a-4841-b8c2-94eb1bb1c724@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=anjo@rev.ng \
--cc=arikalo@gmail.com \
--cc=aurelien@aurel32.net \
--cc=chenhuacai@kernel.org \
--cc=erdnaxe@crans.org \
--cc=jasowang@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=ma.mandourr@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=paulburton@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=svens@stackframe.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).