qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>,
	thuth@redhat.com, cohuck@redhat.com, borntraeger@de.ibm.com
Subject: Re: [Qemu-devel] [PATCH v1 3/6] target/s390x: implement spm (SET PROGRAM MASK)
Date: Sun, 23 Jul 2017 21:39:06 -0700	[thread overview]
Message-ID: <ac7c2032-deed-21b5-8252-d28797e05bf6@twiddle.net> (raw)
In-Reply-To: <20170721125609.11117-4-david@redhat.com>

On 07/21/2017 05:56 AM, David Hildenbrand wrote:
> +    tcg_gen_extrl_i64_i32(cc, o->in1);
> +    tcg_gen_shri_i32(cc, cc, 28);
> +    tcg_gen_andi_i32(cc, cc, 0x3ul);
> +    tcg_gen_mov_i32(cc_op, cc);
> +    tcg_temp_free_i32(cc);
> +    set_cc_static(s);

  tcg_gen_extrl_i64_i32(cc_op, o->in1);
  tcg_gen_extract_i32(cc_op, cc_op, 28, 2);


Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~

  reply	other threads:[~2017-07-24  4:39 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21 12:56 [Qemu-devel] [PATCH v1 0/6] target/s390x: tcg improvments + MSA functions David Hildenbrand
2017-07-21 12:56 ` [Qemu-devel] [PATCH v1 1/6] target/s390x: fix pgm irq ilen for stsi David Hildenbrand
2017-07-24 14:23   ` Thomas Huth
2017-07-25 15:38   ` Cornelia Huck
2017-07-21 12:56 ` [Qemu-devel] [PATCH v1 2/6] target/s390x: fix pgm irq ilen in translate_pages() David Hildenbrand
2017-07-24 14:37   ` Thomas Huth
2017-07-25 15:39   ` Cornelia Huck
2017-07-21 12:56 ` [Qemu-devel] [PATCH v1 3/6] target/s390x: implement spm (SET PROGRAM MASK) David Hildenbrand
2017-07-24  4:39   ` Richard Henderson [this message]
2017-07-24 17:25     ` David Hildenbrand
2017-07-21 12:56 ` [Qemu-devel] [PATCH v1 4/6] target/s390x: move wrap_address to cpu.h David Hildenbrand
2017-07-24  4:40   ` Richard Henderson
2017-07-24 17:38     ` David Hildenbrand
2017-07-24 18:00       ` Richard Henderson
2017-07-24 18:00         ` David Hildenbrand
2017-07-21 12:56 ` [Qemu-devel] [PATCH v1 5/6] target/s390x: add basic MSA features David Hildenbrand
2017-08-09 13:01   ` Cornelia Huck
2017-08-09 13:13     ` Thomas Huth
2017-08-09 13:25     ` David Hildenbrand
2017-08-09 13:29       ` Cornelia Huck
2017-07-21 12:56 ` [Qemu-devel] [PATCH v1 6/6] target/s390x: various alignment check David Hildenbrand
2017-07-21 13:26 ` [Qemu-devel] [PATCH v1 0/6] target/s390x: tcg improvments + MSA functions no-reply
2017-07-24  3:16 ` Richard Henderson
2017-07-24 17:58   ` David Hildenbrand
2017-07-25 11:55 ` Cornelia Huck
2017-07-25 12:16   ` David Hildenbrand
2017-07-25 12:45     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac7c2032-deed-21b5-8252-d28797e05bf6@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aurelien@aurel32.net \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).