From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA1AC433E0 for ; Thu, 6 Aug 2020 13:34:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A836A2312D for ; Thu, 6 Aug 2020 13:34:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QZPwcpg6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A836A2312D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3g2o-0000oU-Om for qemu-devel@archiver.kernel.org; Thu, 06 Aug 2020 09:34:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3g1v-000802-O1; Thu, 06 Aug 2020 09:33:59 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:34975) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3g1u-0002Nr-2a; Thu, 06 Aug 2020 09:33:59 -0400 Received: by mail-wr1-x443.google.com with SMTP id f1so43484499wro.2; Thu, 06 Aug 2020 06:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=D9NfrfC0Ig01+bi+8DPpUem5HnxjvhzhF8q23cyqaA0=; b=QZPwcpg6ozffs4LvP8E3MOi2QTuk4e7khLtUzxKDhiNCpC3vuPFEmOoHwdHmJ4ZSrC qXGlbMbj0fRmbK8UmyAlccDoP7Rnw2zljPCKS0cQ/sWomCdLuIWsgzdyA3L2cXUCSHHr gZiUi/jxtkq+CQp1lguApZOxkm3dHg2sq/W914extDkCM7q7JJ4CZX1RhLOPhv3pYMhy pE5blyKl0ZJ3bxZONCvlYTXmRlMxTGfCa/8awTau/d0lvJDPsbd8vtufyJKGlvvdPmlo mMUhdswiK5wKdvTxv0piSWAiHNfT1q2qE7s/P2+4hP7k7js9m3bqd1xmh1uA0RSeU++Y /5Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=D9NfrfC0Ig01+bi+8DPpUem5HnxjvhzhF8q23cyqaA0=; b=rszWVy6RNU13YRZBAaYDhAXeQDc5QVfOzGNiWyGe4E9DPk6BwGr6xsqkGT3ONgNNnu hkQnowYSTud+ZZOeiSNVt5WK8rJ26ZOEXIZ5dS+5ty7c+d9Gh1qqqra4ZM/6y7//hMID /AkuC4ZgD15niF5sPyuCuMtjsycxV2MxL0JZM/3HP/R9jmT4F/x2QkltbgN/nCPY4C8a mDg3LMoZFtGzTCbsz5eIjpYM1Fb2oyWBjLlwb3+XLCk+lEE1xWktmsfJZ9zH2rxn1Glw iu8yFtAkgK05HZl6usr74y2eQjKxi4Y93DCbbJX6ojWYD9Q3oIuOrRMFm4J5+7W4R/5N VP9g== X-Gm-Message-State: AOAM533+OwWZT5i4bDco2LGjJqlJW702n6v845RAd+ppyCZ3yjzV3HBj PctK6T9JDD4H6I0J1PlY5R0= X-Google-Smtp-Source: ABdhPJwcXTAlXHwMA+eRT4PgbXcn6gLnWKwpHw7rGkh6l9kocZ9NGX3IlS/mrELYQuyF4UaKH1P7Mg== X-Received: by 2002:adf:a3d0:: with SMTP id m16mr7095362wrb.232.1596720835989; Thu, 06 Aug 2020 06:33:55 -0700 (PDT) Received: from [192.168.1.36] (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id 69sm6914842wmb.8.2020.08.06.06.33.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2020 06:33:55 -0700 (PDT) Subject: Re: [PATCH for-5.2 09/19] ftgmac100: Fix registers that can be read To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Peter Maydell References: <20200806132106.747414-1-clg@kaod.org> <20200806132106.747414-10-clg@kaod.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Thu, 6 Aug 2020 15:33:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200806132106.747414-10-clg@kaod.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::443; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , qemu-arm@nongnu.org, Joel Stanley , qemu-devel@nongnu.org, Frederic Konrad Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/6/20 3:20 PM, Cédric Le Goater wrote: > Receive Ring Base Address Register (RXR_BADR) and the Normal Priority > Transmit Receive Ring Base Address Register (NPTXR_BADR) can als be typo "also" Reviewed-by: Philippe Mathieu-Daudé > read. > > Cc: Frederic Konrad > Signed-off-by: Cédric Le Goater > --- > hw/net/ftgmac100.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/net/ftgmac100.c b/hw/net/ftgmac100.c > index 5f4b26fc5f3c..0348fcf45676 100644 > --- a/hw/net/ftgmac100.c > +++ b/hw/net/ftgmac100.c > @@ -669,6 +669,10 @@ static uint64_t ftgmac100_read(void *opaque, hwaddr addr, unsigned size) > return s->math[0]; > case FTGMAC100_MATH1: > return s->math[1]; > + case FTGMAC100_RXR_BADR: > + return s->rx_ring; > + case FTGMAC100_NPTXR_BADR: > + return s->tx_ring; > case FTGMAC100_ITC: > return s->itc; > case FTGMAC100_DBLAC: >