From: Richard Henderson <richard.henderson@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Andreas Krebbel" <krebbel@linux.ibm.com>
Subject: Re: [PATCH v3] accel/tcg: Clear PAGE_WRITE before translation
Date: Mon, 16 Aug 2021 08:23:23 -1000 [thread overview]
Message-ID: <ac89e57c-7b21-f554-f23c-9423957eb791@linaro.org> (raw)
In-Reply-To: <20210805204835.158918-1-iii@linux.ibm.com>
On 8/5/21 10:48 AM, Ilya Leoshkevich wrote:
> translate_insn() implementations fetch instruction bytes piecemeal,
> which can cause qemu-user to generate inconsistent translations if
> another thread modifies them concurrently [1].
>
> Fix by making pages containing translated instruction non-writable
> right before loading instruction bytes from them.
>
> [1] https://lists.nongnu.org/archive/html/qemu-devel/2021-08/msg00644.html
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
>
> v2: https://lists.nongnu.org/archive/html/qemu-devel/2021-08/msg00819.html
> v2 -> v3: Move translator_ld*_swap() functions from translator.h into
> translator.c for a better size trade-off (Richard).
Thanks, queued.
I've split apart the patch so that we add the argument (and make all of the other changes
to target/) before actually changing the mapping.
r~
prev parent reply other threads:[~2021-08-16 18:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 20:48 [PATCH v3] accel/tcg: Clear PAGE_WRITE before translation Ilya Leoshkevich
2021-08-16 18:23 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac89e57c-7b21-f554-f23c-9423957eb791@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=dgilbert@redhat.com \
--cc=iii@linux.ibm.com \
--cc=krebbel@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).