Re: [RFC PATCH] meson.build: don't include libbpf in the common source set

[Paolo Bonzini <pbonzini@redhat.com>]

On 05/10/21 21:00, Philippe Mathieu-Daudé wrote:
> On 10/5/21 20:24, Alex Bennée wrote:
>> This library is only needed for the softmmu targets and as such
>> break static *-user builds where libbpf is detected and it tries to
>> link it into the user binaries.
>>
>> Fixes: 46627f41b6 ("ebpf: Added eBPF RSS loader.")
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>   meson.build | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meson.build b/meson.build
>> index 60f4f45165..d8bcf13b21 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -2307,7 +2307,7 @@ subdir('bsd-user')
>>   subdir('linux-user')
>>   subdir('ebpf')
>>   
>> -common_ss.add(libbpf)
>> +softmmu_ss.add(libbpf)
>>   
>>   bsd_user_ss.add(files('gdbstub.c'))
>>   specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss)
>>
> 
> Patch already pending on the list:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg834876.html

Not the same patch, that one is already in.

Paolo