From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org,
"Alistair Francis" <alistair.francis@wdc.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
dirty.ice.hu@gmail.com, "Robert Hoo" <robert.hu@linux.intel.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: Let's remove some deprecated stuff
Date: Mon, 3 May 2021 17:10:51 +0200 [thread overview]
Message-ID: <ac964003-8358-dfc6-dc6e-edb830541e0f@redhat.com> (raw)
In-Reply-To: <20210429124049.z7qtkufk2wgvvd5i@sirius.home.kraxel.org>
On 29/04/21 14:40, Gerd Hoffmann wrote:
>> In other words you would do something like -audiohw
>> <audiodev-args>,model=xxx and it gets desugared automatically to either
>>
>> -audiodev <audiodev-args>,id=foo -device devname,audiodev=xxx
>>
>> or
>>
>> -audiodev <audiodev-args>,id=foo -M propname=foo
> Suggestions how to do that in a clean way?
> Given that -audiodev is qapi-based I tried it this way:
Since this is sugar, I think it's okay to make it desugar into QAPI,
instead of being QAPI all the way down:
- use qobject_input_visitor_new_str in softmmu/vl.c
- visit the "model" key
- look up the "model", fail if it doesn't match a known model
- pass the rest into a variant of audio_parse_option that takes a
Visitor and returns and Audiodev*
- pass the id into a constructor function keyed by the model
Paolo
next prev parent reply other threads:[~2021-05-03 15:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 9:59 Let's remove some deprecated stuff Markus Armbruster
2021-04-29 10:18 ` Gerd Hoffmann
2021-04-29 10:24 ` Daniel P. Berrangé
2021-04-29 10:29 ` Peter Maydell
2021-04-29 10:35 ` Daniel P. Berrangé
2021-04-29 10:55 ` Gerd Hoffmann
2021-04-30 10:47 ` Markus Armbruster
2021-04-29 11:07 ` Paolo Bonzini
2021-04-29 10:25 ` Peter Maydell
2021-04-29 10:32 ` Daniel P. Berrangé
2021-04-30 6:47 ` Markus Armbruster
2021-04-29 11:06 ` Paolo Bonzini
2021-04-29 12:40 ` Gerd Hoffmann
2021-04-29 13:12 ` Kevin Wolf
2021-04-29 13:46 ` Gerd Hoffmann
2021-04-29 15:05 ` Philippe Mathieu-Daudé
2021-04-30 7:01 ` Markus Armbruster
2021-04-30 7:01 ` Gerd Hoffmann
2021-05-03 15:10 ` Paolo Bonzini [this message]
2021-04-29 11:17 ` Thomas Huth
2021-04-29 11:24 ` Peter Maydell
2021-05-03 10:39 ` Markus Armbruster
2021-04-29 14:49 ` Stefan Hajnoczi
2021-04-29 16:32 ` Eduardo Habkost
2021-04-30 3:22 ` Robert Hoo
2021-05-03 1:41 ` Alistair Francis
2021-05-03 4:49 ` Thomas Huth
2021-05-03 7:12 ` Alistair Francis
2021-05-03 15:13 ` Paolo Bonzini
2021-05-03 22:57 ` Alistair Francis
2021-05-03 13:14 ` Philippe Mathieu-Daudé
2021-05-03 18:21 ` Eric Blake
2021-05-04 13:59 ` Peter Krempa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac964003-8358-dfc6-dc6e-edb830541e0f@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dirty.ice.hu@gmail.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=robert.hu@linux.intel.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).