Re: [PATCH RFC 5/9] migration: Thread-ify precopy vmstate load process

["Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>]

On 28/08/2025 04:59, Peter Xu wrote:
> diff --git a/migration/rdma.c b/migration/rdma.c
> index bcd7aae2f2..2b995513aa 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -3068,7 +3068,6 @@ static void rdma_cm_poll_handler(void *opaque)
>   {
>       RDMAContext *rdma = opaque;
>       struct rdma_cm_event *cm_event;
> -    MigrationIncomingState *mis = migration_incoming_get_current();
>   
>       if (rdma_get_cm_event(rdma->channel, &cm_event) < 0) {
>           error_report("get_cm_event failed %d", errno);
> @@ -3087,10 +3086,6 @@ static void rdma_cm_poll_handler(void *opaque)
>               }
>           }
>           rdma_ack_cm_event(cm_event);


This above line should be removed as well, otherwise it will cause a double cm_event free.




> -        if (mis->loadvm_co) {
> -            qemu_coroutine_enter(mis->loadvm_co);
> -        }
> -        return;
>       }
>       rdma_ack_cm_event(cm_event);
>   }