From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 304B1CAC592 for ; Mon, 22 Sep 2025 16:03:23 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v0izm-0006vn-Mt; Mon, 22 Sep 2025 12:02:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v0izj-0006uh-GQ for qemu-devel@nongnu.org; Mon, 22 Sep 2025 12:02:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v0izg-0005wL-Aj for qemu-devel@nongnu.org; Mon, 22 Sep 2025 12:02:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758556942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vZEk6Gfa9M9fnje5QIWK6y0ycztYFBK0qLYlkro1DqU=; b=AdNXBpYawsWjTM1RC1JeHySQwXvo67qthP5pwAIAgHBA3R+zES8dhO4O0BBrRCePt28HNE uHDFPCKvd2rQpPvuXgSd7rw1UXQgEbeegtsKoyUOW7eWu3mJsCiogC7bhcG6aUosFIMbCL xkE2cm9A9+q32Kzppoz9vFoilAPd3XQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-37-Zdf_1XcvPryBmVsGOsQM6w-1; Mon, 22 Sep 2025 12:02:20 -0400 X-MC-Unique: Zdf_1XcvPryBmVsGOsQM6w-1 X-Mimecast-MFC-AGG-ID: Zdf_1XcvPryBmVsGOsQM6w_1758556939 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3ecdc9dbc5fso3266854f8f.1 for ; Mon, 22 Sep 2025 09:02:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758556939; x=1759161739; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vZEk6Gfa9M9fnje5QIWK6y0ycztYFBK0qLYlkro1DqU=; b=KbpBz9dfRNKkl0Q/HZUleDsN0KPHyam7SHc5AWjoRgsqFjRRXuR9PFcIFQvAdxjv2T WC7grRu0TojINCIBFLTEysxtXd1pblJqp1k0Y989Rzl4u8PNmdl8gD5w3uE7HJaZsYHJ Qt4GEcGwl5a/HFDAcwXiRYvIHlyiTlA8Tu+QoDdVp/jQ+/4WqYSJp8FMKGm12kWIbm+G 7Hwg31PAPXAp/o182sQhTa7v/SHwsK4pL5C6Mt1X4SakcZ3LtPbbjxfW/ZCUcufnwcoY zSpapCZw9jk3I79i3Iq4NytukHKYIvTms7Ni9pQGV/5FJWQkwKCAl/Pt4beoRVJixeF5 yIQQ== X-Forwarded-Encrypted: i=1; AJvYcCVbcWIjCuVGxKwXeOSam9HXoDlu/JfrZ9TZFLpZ5e9z6JbSZ3Rd8bbvz2/a1FRHxTsiSvvDLoJyXRme@nongnu.org X-Gm-Message-State: AOJu0Yx6L5e/Bl0dqADRmHkkIpGvTXbFmvMZMgh6YU7rXsePVdtoeK0q Gc01mHhJazgjDrYgeY+kNYxfuJg7lD4x6JFoYbKJwxGwScMwIEIiWxAiy0pj6P/dc85Q/WvSOcZ qhEHO1y0WsvSWAp1MSltegZmFBFZzonWdbCaX/dmWupoZ3xtiHkhPIeU3 X-Gm-Gg: ASbGncuCT9vUfML09/q9e7VwPCRj+BZrFexUnfrDxq77DhrJNyEL3uWXaa2Ha/VuAU2 ltKF/IeC4+AQ2cM5ECYhLGzgc3MXzl/MR0YOR4fcL9YYjASBcytUqc8iXeSyqcLNhGeazPfDPJq TBsbAuLicbDCFgKhYdEUwXGvlGhFdpawHqkqBkeR9ftbJiVrQ6N86VLv9azbJmRtaqFWRgvyFGN 9trJJSo7k0vPNKqSHdh1bt3JopIiyteoiFrABSbfEsrdfEYbpRVpJtNv/ixvQJUxVklf7k8c+sJ BvxpA35rKrrYeX0qTYKsRTqjq9hHGqLjHrgEY4eT+bEDNUwxQYELAA3yiyzoWkOrorVGTdFO9vu 6fNc= X-Received: by 2002:a05:6000:1885:b0:3ec:dbc7:3c71 with SMTP id ffacd0b85a97d-3ee87e9c885mr12443912f8f.62.1758556939263; Mon, 22 Sep 2025 09:02:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9yBitQdtFIrQSRcZ2d9qWKZaPslGXW/eJr8hMX5mzf7ROFADZyYZRqtn9m11bnkjhG9BFrw== X-Received: by 2002:a05:6000:1885:b0:3ec:dbc7:3c71 with SMTP id ffacd0b85a97d-3ee87e9c885mr12443875f8f.62.1758556938741; Mon, 22 Sep 2025 09:02:18 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:576b:abc6:6396:ed4a? ([2a01:e0a:280:24f0:576b:abc6:6396:ed4a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46d7a566a27sm40368335e9.20.2025.09.22.09.02.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Sep 2025 09:02:18 -0700 (PDT) Message-ID: Date: Mon, 22 Sep 2025 18:02:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] vfio/iommufd: Add IOMMU_HWPT_GET_DIRTY_BITMAP_NO_CLEAR flag support To: "Duan, Zhenzhong" , Joao Martins , "qemu-devel@nongnu.org" Cc: "alex.williamson@redhat.com" , "mst@redhat.com" , "jasowang@redhat.com" , "Liu, Yi L" , "clement.mathieu--drif@eviden.com" , "eric.auger@redhat.com" , "avihaih@nvidia.com" , "Hao, Xudong" , "Cabiddu, Giovanni" , "Gross, Mark" , "Van De Ven, Arjan" References: <20250910023701.244356-1-zhenzhong.duan@intel.com> <20250910023701.244356-4-zhenzhong.duan@intel.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Language: en-US, fr Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 9/22/25 07:49, Duan, Zhenzhong wrote: > Hi Joao, > >> -----Original Message----- >> From: Joao Martins >> Subject: Re: [PATCH 3/5] vfio/iommufd: Add >> IOMMU_HWPT_GET_DIRTY_BITMAP_NO_CLEAR flag support >> >> On 10/09/2025 03:36, Zhenzhong Duan wrote: >>> Pass IOMMU_HWPT_GET_DIRTY_BITMAP_NO_CLEAR when doing the last >> dirty >>> bitmap query right before unmap, no PTEs flushes. This accelerates the >>> query without issue because unmap will tear down the mapping anyway. >>> >>> Add a new element dirty_tracking_flags in VFIOIOMMUFDContainer to >>> be used for the flags of iommufd dirty tracking. Currently it is >>> set to either IOMMU_HWPT_GET_DIRTY_BITMAP_NO_CLEAR or 0 based on >>> the scenario. >>> >>> Co-developed-by: Joao Martins >>> Signed-off-by: Joao Martins >>> Signed-off-by: Zhenzhong Duan >>> Tested-by: Xudong Hao >>> Tested-by: Giovannio Cabiddu >>> --- >>> hw/vfio/vfio-iommufd.h | 1 + >>> include/system/iommufd.h | 2 +- >>> backends/iommufd.c | 5 +++-- >>> hw/vfio/iommufd.c | 6 +++++- >>> backends/trace-events | 2 +- >>> 5 files changed, 11 insertions(+), 5 deletions(-) >>> >>> diff --git a/hw/vfio/vfio-iommufd.h b/hw/vfio/vfio-iommufd.h >>> index 07ea0f4304..e0af241c75 100644 >>> --- a/hw/vfio/vfio-iommufd.h >>> +++ b/hw/vfio/vfio-iommufd.h >>> @@ -26,6 +26,7 @@ typedef struct VFIOIOMMUFDContainer { >>> VFIOContainerBase bcontainer; >>> IOMMUFDBackend *be; >>> uint32_t ioas_id; >>> + uint64_t dirty_tracking_flags; >>> QLIST_HEAD(, VFIOIOASHwpt) hwpt_list; >>> } VFIOIOMMUFDContainer; >>> >>> diff --git a/include/system/iommufd.h b/include/system/iommufd.h >>> index c9c72ffc45..63898e7b0d 100644 >>> --- a/include/system/iommufd.h >>> +++ b/include/system/iommufd.h >>> @@ -64,7 +64,7 @@ bool >> iommufd_backend_set_dirty_tracking(IOMMUFDBackend *be, uint32_t >> hwpt_id, >>> bool iommufd_backend_get_dirty_bitmap(IOMMUFDBackend *be, >> uint32_t hwpt_id, >>> uint64_t iova, ram_addr_t >> size, >>> uint64_t page_size, >> uint64_t *data, >>> - Error **errp); >>> + uint64_t flags, Error >> **errp); >>> bool iommufd_backend_invalidate_cache(IOMMUFDBackend *be, >> uint32_t id, >>> uint32_t data_type, >> uint32_t entry_len, >>> uint32_t *entry_num, void >> *data, >>> diff --git a/backends/iommufd.c b/backends/iommufd.c >>> index 2a33c7ab0b..3c4f6157e2 100644 >>> --- a/backends/iommufd.c >>> +++ b/backends/iommufd.c >>> @@ -361,7 +361,7 @@ bool >> iommufd_backend_get_dirty_bitmap(IOMMUFDBackend *be, >>> uint32_t hwpt_id, >>> uint64_t iova, ram_addr_t >> size, >>> uint64_t page_size, >> uint64_t *data, >>> - Error **errp) >>> + uint64_t flags, Error **errp) >>> { >>> int ret; >>> struct iommu_hwpt_get_dirty_bitmap get_dirty_bitmap = { >>> @@ -371,11 +371,12 @@ bool >> iommufd_backend_get_dirty_bitmap(IOMMUFDBackend *be, >>> .length = size, >>> .page_size = page_size, >>> .data = (uintptr_t)data, >>> + .flags = flags, >>> }; >>> >>> ret = ioctl(be->fd, IOMMU_HWPT_GET_DIRTY_BITMAP, >> &get_dirty_bitmap); >>> trace_iommufd_backend_get_dirty_bitmap(be->fd, hwpt_id, iova, >> size, >>> - page_size, ret ? errno : >> 0); >>> + flags, page_size, ret ? >> errno : 0); >>> if (ret) { >>> error_setg_errno(errp, errno, >>> "IOMMU_HWPT_GET_DIRTY_BITMAP >> (iova: 0x%"HWADDR_PRIx >>> diff --git a/hw/vfio/iommufd.c b/hw/vfio/iommufd.c >>> index 0057488ce9..c897aa6b17 100644 >>> --- a/hw/vfio/iommufd.c >>> +++ b/hw/vfio/iommufd.c >>> @@ -62,7 +62,7 @@ static int iommufd_cdev_unmap_one(const >> VFIOContainerBase *bcontainer, >>> hwaddr iova, ram_addr_t size, >>> IOMMUTLBEntry *iotlb) >>> { >>> - const VFIOIOMMUFDContainer *container = >>> + VFIOIOMMUFDContainer *container = >>> container_of(bcontainer, VFIOIOMMUFDContainer, >> bcontainer); >>> bool need_dirty_sync = false; >>> Error *local_err = NULL; >>> @@ -73,9 +73,12 @@ static int iommufd_cdev_unmap_one(const >> VFIOContainerBase *bcontainer, >>> if (iotlb && vfio_container_dirty_tracking_is_started(bcontainer)) { >>> if >> (!vfio_container_devices_dirty_tracking_is_supported(bcontainer) && >>> bcontainer->dirty_pages_supported) { >>> + container->dirty_tracking_flags = >>> + >> IOMMU_HWPT_GET_DIRTY_BITMAP_NO_CLEAR; >>> ret = vfio_container_query_dirty_bitmap(bcontainer, iova, >> size, >>> >> iotlb->translated_addr, >>> >> &local_err); >>> + container->dirty_tracking_flags = 0; >> >> Why not changing vfio_container_query_dirty_bitmap to pass a flags too, like >> the >> original patches? This is a little unnecssary odd style to pass a flag via >> container structure rather and then clearing. > > Just want to be simpler, original patch introduced a new parameter to almost all > variants of *_query_dirty_bitmap() while the flags parameter is only used by > IOMMUFD backend when doing unmap_bitmap. Currently we already have three > backends, legacy VFIO, IOMMUFD and VFIO-user, only IOMMUFD need the flag. > > I take container->dirty_tracking_flags as a notification mechanism, so set it before > vfio_container_query_dirty_bitmap() and clear it thereafter. Maybe clearing it in > iommufd_query_dirty_bitmap() is easier to be acceptable? > >> >> Part of the reason the original series had a VFIO_GET_DIRTY_NO_FLUSH for >> generic >> container abstraction was to not mix IOMMUFD UAPI specifics into base >> container >> API. Then in getting a VFIO_GET_DIRTY_NO_FLUSH, then type1 backend >> could just >> ignore the flag, while IOMMUFD translates it to >> IOMMU_HWPT_GET_DIRTY_BITMAP_NO_CLEAR > > I did port original patch https://github.com/yiliu1765/qemu/commit/99f83595d79d2e4170c9e456cf1a7b9521bd4f80 > But it looks complex to have 'flags' parameter everywhere. I think I would prefer like Joao to avoid caching information if possible but I haven't check closely the mess it would introduce in the code. Let me check. Thanks, C.