From: Magnus Kulke <magnuskulke@linux.microsoft.com>
To: Anirudh Rayabharam <anirudh@anirudhrb.com>
Cc: qemu-devel@nongnu.org, Zhao Liu <zhao1.liu@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Wei Liu <liuwe@microsoft.com>,
Magnus Kulke <magnuskulke@microsoft.com>,
Wei Liu <wei.liu@kernel.org>
Subject: Re: [PATCH v2 1/9] accel/mshv: use mshv_create_partition_v2 payload
Date: Mon, 23 Mar 2026 11:55:22 +0100 [thread overview]
Message-ID: <acEcGhuIsOm27yUo@example.com> (raw)
In-Reply-To: <20260312-tested-garnet-hippo-cb71ee@anirudhrb>
On Thu, Mar 12, 2026 at 10:47:24AM +0000, Anirudh Rayabharam wrote:
> Why not just call the param property_code instead of feature_bank? That
> way this function can be used for other properties too.
>
makes sense
> > + QEMU_BUILD_BUG_ON(ARRAY_SIZE(feature_banks) > MSHV_NUM_CPU_FEATURES_BANKS);
>
> Is this really useful since we're not using the feature_banks array
> anywhere?
>
yeah that's arguable. the intent is to detect drift between the number of
feature banks defined in the header and what we handle in the args. we
can just assert == 2 for now.
thanks,
magnus
next prev parent reply other threads:[~2026-03-23 10:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 11:34 [PATCH v2 0/9] Support QEMU cpu models in MSHV accelerator Magnus Kulke
2026-03-11 11:34 ` [PATCH v2 1/9] accel/mshv: use mshv_create_partition_v2 payload Magnus Kulke
2026-03-11 20:54 ` Wei Liu
2026-03-12 10:47 ` Anirudh Rayabharam
2026-03-12 10:53 ` Anirudh Rayabharam
2026-03-12 10:55 ` [PATCH v2 9/9] accel/mshv: disable la57 (5lvl paging) Anirudh Rayabharam
2026-03-23 10:55 ` Magnus Kulke [this message]
2026-03-11 11:34 ` [PATCH v2 2/9] target/i386/mshv: fix cpuid propagation bug Magnus Kulke
2026-03-11 11:40 ` Philippe Mathieu-Daudé
2026-03-11 11:34 ` [PATCH v2 3/9] target/i386/mshv: fix various cpuid traversal bugs Magnus Kulke
2026-03-11 20:58 ` Wei Liu
2026-03-11 11:35 ` [PATCH v2 4/9] target/i386/mshv: change cpuid mask to UINT32_MAX Magnus Kulke
2026-03-11 21:36 ` Wei Liu
2026-03-11 11:35 ` [PATCH v2 5/9] target/i386/mshv: set cpu model name on -cpu host Magnus Kulke
2026-03-11 21:37 ` Wei Liu
2026-03-11 11:35 ` [PATCH v2 6/9] target/i386: query mshv accel for supported cpuids Magnus Kulke
2026-03-11 11:35 ` [PATCH v2 7/9] target/i386/mshv: populate xsave area offsets Magnus Kulke
2026-03-11 11:35 ` [PATCH v2 8/9] target/i386/mshv: filter out CET bits in cpuid Magnus Kulke
2026-03-11 11:35 ` [PATCH v2 9/9] accel/mshv: disable la57 (5lvl paging) Magnus Kulke
2026-03-11 11:54 ` Mohamed Mediouni
2026-03-11 15:17 ` Magnus Kulke
2026-03-11 15:31 ` Mohamed Mediouni
2026-03-11 18:40 ` Magnus Kulke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acEcGhuIsOm27yUo@example.com \
--to=magnuskulke@linux.microsoft.com \
--cc=anirudh@anirudhrb.com \
--cc=liuwe@microsoft.com \
--cc=magnuskulke@microsoft.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wei.liu@kernel.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox