From: Kevin Wolf <kwolf@redhat.com>
To: long.yunjian@zte.com.cn
Cc: hreitz@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org,
mou.yi@zte.com.cn, liang.xianlong@zte.com.cn
Subject: Re: [PATCH] block: fix annotation
Date: Tue, 24 Mar 2026 10:47:55 +0100 [thread overview]
Message-ID: <acJdy1R7nojlNVrW@redhat.com> (raw)
In-Reply-To: <20260320091745976o3u3XYI9SyVZ0siV2roHH@zte.com.cn>
Am 20.03.2026 um 02:17 hat long.yunjian@zte.com.cn geschrieben:
> From: Yunjian Long <long.yunjian@zte.com.cn>
>
> The bdrv_bsc_is_data function is defined in block_int-io.h,
> so the correct annotation is block_int-io.h rather than block_int.h
>
> Signed-off-by: Yunjian Long <long.yunjian@zte.com.cn>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block.c b/block.c
> index 48a17f393c..3166114890 100644
> --- a/block.c
> +++ b/block.c
> @@ -8477,7 +8477,7 @@ static bool bdrv_bsc_range_overlaps_locked(BlockDriverState *bs,
> }
>
> /**
> - * See block_int.h for this function's documentation.
> + * See block_int-io.h for this function's documentation.
> */
> bool bdrv_bsc_is_data(BlockDriverState *bs, int64_t offset, int64_t *pnum)
> {
That's right, good catch. A few lines down there is the same problem in
bdrv_bsc_invalidate_range() and bdrv_bsc_fill(). Can you please fix all
of them at once in a v2 patch?
Kevin
prev parent reply other threads:[~2026-03-24 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 1:17 [PATCH] block: fix annotation long.yunjian
2026-03-24 9:47 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acJdy1R7nojlNVrW@redhat.com \
--to=kwolf@redhat.com \
--cc=hreitz@redhat.com \
--cc=liang.xianlong@zte.com.cn \
--cc=long.yunjian@zte.com.cn \
--cc=mou.yi@zte.com.cn \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox