qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Giovanni Mascellani <gio@debian.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	Cornelia Huck <cohuck@redhat.com>,
	David Hildenbrand <david@redhat.com>
Cc: Bug 1815024 <1815024@bugs.launchpad.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Bug 1815024] [NEW] SIGILL on instruction "stck" under qemu-s390x in user mode
Date: Thu, 7 Feb 2019 14:09:00 +0100	[thread overview]
Message-ID: <aca8026e-4463-a09e-d9bd-2df0791d1fb9@redhat.com> (raw)
In-Reply-To: <175f1e54-4517-d815-f6ac-566be14bfc3a@debian.org>

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

On 2019-02-07 14:00, Giovanni Mascellani wrote:
> Hi,
> 
> Il 07/02/19 13:15, Richard Henderson ha scritto:
>> See also
>>
>>   https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg06734.html
>>
>> which I never followed up on the review changes requested.
> 
> I can confirm that both patches (Thomas' and Richard's) work for me.
> Although they produce rather different results:
> 
>  Thomas' patch:   around 6346926678828662276
>  Richard's patch: around 9048173079139739571
> 
> They also appear to grow at different speeds, if I am not mistaken. I
> have no idea of what is correct, because I do not know s390x.

Both are wrong. I missed to add the TOD_UNIX_EPOCH offset, and Richard
missed to use the time2tod() conversion.

Anyway, I yield to Richard's patches since he posted his patches first
(unless he does not have any spare time to work on it at all, then I
could have another look).

 Thomas


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2019-02-07 13:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07  9:46 [Qemu-devel] [Bug 1815024] [NEW] SIGILL on instruction "stck" under qemu-s390x in user mode Giovanni Mascellani
2019-02-07  9:46 ` [Qemu-devel] [Bug 1815024] " Giovanni Mascellani
2019-02-07  9:46 ` Giovanni Mascellani
2019-02-07  9:48 ` Giovanni Mascellani
2019-02-07 10:49 ` [Qemu-devel] [Bug 1815024] [NEW] " Cornelia Huck
2019-02-07 11:05   ` Giovanni Mascellani
2019-02-07 11:26     ` Thomas Huth
2019-02-07 11:46       ` Giovanni Mascellani
2019-02-07 12:01         ` Thomas Huth
2019-02-07 12:15           ` Richard Henderson
2019-02-07 12:36             ` Thomas Huth
2019-02-07 13:05               ` Richard Henderson
2019-02-07 13:00             ` Giovanni Mascellani
2019-02-07 13:09               ` Thomas Huth [this message]
2019-02-22 15:24 ` [Qemu-devel] [Bug 1815024] " Thomas Huth
2019-04-24  6:09 ` Thomas Huth
2019-04-24  6:09   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aca8026e-4463-a09e-d9bd-2df0791d1fb9@redhat.com \
    --to=thuth@redhat.com \
    --cc=1815024@bugs.launchpad.net \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=gio@debian.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).