From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Thomas Weißschuh" <thomas@t-8ch.de>, qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH] linux-user: report ENOTTY for unknown ioctls
Date: Wed, 26 Apr 2023 12:04:56 +0100 [thread overview]
Message-ID: <acbcec45-0689-21c7-2a3c-36ad0be45ea8@linaro.org> (raw)
In-Reply-To: <20230426070659.80649-1-thomas@t-8ch.de>
On 26/4/23 09:06, Thomas Weißschuh wrote:
> The correct error number for unknown ioctls is ENOTTY.
>
> ENOSYS would mean that the ioctl() syscall itself is not implemented,
> which is very improbable and unexpected for userspace.
>
> ENOTTY means "Inappropriate ioctl for device". This is what the kernel
> returns on unknown ioctls, what qemu is trying to express and what
> userspace is prepared to handle.
>
> Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
> ---
> linux-user/syscall.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-04-26 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 7:06 [PATCH] linux-user: report ENOTTY for unknown ioctls Thomas Weißschuh
2023-04-26 11:04 ` Philippe Mathieu-Daudé [this message]
2023-05-01 15:07 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acbcec45-0689-21c7-2a3c-36ad0be45ea8@linaro.org \
--to=philmd@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=thomas@t-8ch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).