From: Stefan Berger <stefanb@linux.ibm.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 00/11] tpm: Split hw/ vs backends/
Date: Thu, 11 Jun 2020 12:21:06 -0400 [thread overview]
Message-ID: <accbc334-8481-de41-047b-740c27142f63@linux.ibm.com> (raw)
In-Reply-To: <20200611160306.2751-1-philmd@redhat.com>
On 6/11/20 12:02 PM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> Yesterday I started to review some vTPM patches and got very
> confused by the files under hw/tpm/. In particular after
> running:
>
> $ git grep TYPE_TPM_BACKEND
> backends/tpm.c:188: .name = TYPE_TPM_BACKEND,
> hw/tpm/tpm_emulator.c:985: .parent = TYPE_TPM_BACKEND,
> hw/tpm/tpm_passthrough.c:393: .parent = TYPE_TPM_BACKEND,
> include/sysemu/tpm_backend.h:21:#define TYPE_TPM_BACKEND "tpm-backend"
>
> As there is no particular reason to keep this mixed, clean it up.
THANK YOU for the cleanup.
Stefan
next prev parent reply other threads:[~2020-06-11 16:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 16:02 [PATCH v2 00/11] tpm: Split hw/ vs backends/ Philippe Mathieu-Daudé
2020-06-11 16:02 ` [PATCH v2 01/11] docs/specs/tpm: Correct header path name Philippe Mathieu-Daudé
2020-06-11 16:19 ` Stefan Berger
2020-06-11 16:02 ` [PATCH v2 02/11] backends: Add TPM files into their own directory Philippe Mathieu-Daudé
2020-06-11 16:20 ` Stefan Berger
2020-06-11 16:02 ` [PATCH v2 03/11] hw/tpm: Rename TPMDEV as TPM_BACKEND in Kconfig Philippe Mathieu-Daudé
2020-06-11 16:22 ` Stefan Berger
2020-06-11 16:02 ` [PATCH v2 04/11] hw/tpm: Do not include 'qemu/osdep.h' in header Philippe Mathieu-Daudé
2020-06-11 16:03 ` [PATCH v2 05/11] hw/tpm: Include missing 'qemu/option.h' header Philippe Mathieu-Daudé
2020-06-11 16:03 ` [PATCH v2 06/11] hw/tpm: Move 'hw/acpi/tpm.h' inclusion from header to sources Philippe Mathieu-Daudé
2020-06-11 16:03 ` [PATCH v2 07/11] hw/tpm: Remove unnecessary 'tpm_int.h' header inclusion Philippe Mathieu-Daudé
2020-06-11 16:03 ` [PATCH v2 08/11] hw/tpm: Move few declarations from 'tpm_util.h' to 'tpm_int.h' Philippe Mathieu-Daudé
2020-06-11 16:03 ` [PATCH v2 09/11] hw/tpm: Move DEFINE_PROP_TPMBE() macro to 'tmp_prop.h' local header Philippe Mathieu-Daudé
2020-06-11 16:03 ` [PATCH v2 10/11] hw/tpm: Make 'tpm_util.h' publicly accessible as "sysemu/tpm_util.h" Philippe Mathieu-Daudé
2020-06-11 16:03 ` [RFC PATCH v2 11/11] tpm: Move backend code under the 'backends/' directory Philippe Mathieu-Daudé
2020-06-11 16:21 ` Stefan Berger [this message]
2020-06-23 9:39 ` [PATCH v2 00/11] tpm: Split hw/ vs backends/ Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=accbc334-8481-de41-047b-740c27142f63@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).