From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C089C3DA7D for ; Tue, 3 Jan 2023 12:06:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCg2v-0006h6-KW; Tue, 03 Jan 2023 07:05:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCg2l-0006bj-Ca for qemu-devel@nongnu.org; Tue, 03 Jan 2023 07:05:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCg2j-0006dg-NP for qemu-devel@nongnu.org; Tue, 03 Jan 2023 07:05:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672747520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KunRRQUaMrs4fxxOeg85c8Ty+qkUePbiYBVbHpgULag=; b=MpolhWN1paM2An0RDme77fLvdY3Y0tsSII+8ihyWsTz7JveMnkiC3XIsA1Lwe1ZIvu1Ebg je2ZrrcczcXsu/c1emI1higiStPrAvGgINKpuadRdyQpNwxWh1eSDFKjg6DWh8lfK/3+E8 xOV0nqElvPZpDa8nqAJF6+y6/Nbp1U4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-75-OzgRTGeYNpqLSdcRtTNF6w-1; Tue, 03 Jan 2023 07:05:19 -0500 X-MC-Unique: OzgRTGeYNpqLSdcRtTNF6w-1 Received: by mail-wr1-f71.google.com with SMTP id i9-20020adfa509000000b0027df24b887fso2264792wrb.3 for ; Tue, 03 Jan 2023 04:05:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KunRRQUaMrs4fxxOeg85c8Ty+qkUePbiYBVbHpgULag=; b=5MS4pK7sdRZk4DStHG7O8kRIA7OO5MuoR2a7wp4uzCmb+YEMpWNlqP8ZlCCLuqGPiS OOn3+rtyPGVKvjDfq3U2O5TF3rR8pRY/vCGmJf4oWDc1orosS6CFxmKCo6JshQnEyCPJ GpRFknX2VxMnXS1FOhSmqYu+keGvUSVSdz8v6lKQ86uTkAbyVqtyO4DN5Zk78cOlnhn8 dCgqXV9whOZ6pO0ySThQr4WIqc4Wpvmatvjy6Gca5tWpsv4qUxlIYXBL76vO6s0cZUwE MDMUBWeUklXGb5Oao48GviyNQHUMnw8I1xcynNk5Qp+54di3y8ojqu0DCPd6Q5OpsdLB sVZQ== X-Gm-Message-State: AFqh2kqEE7/5hnHr19X/x6CML6FQxMBtfSE1GhVKi1pudKzMAyH/Tz6w 2NM6njo/zsQtSwNQZ5KOelX84t0/AhaKoa0FUCwBGpobCEzWogNFVdSeMWSo++F8BMuB9U6Tn0z UF0SmkXclXOiZmRs= X-Received: by 2002:a05:600c:6016:b0:3d3:3c93:af5e with SMTP id az22-20020a05600c601600b003d33c93af5emr31066936wmb.35.1672747518519; Tue, 03 Jan 2023 04:05:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXvIgd57MuoPYxOEzwNhVdGEv3hv1wd14QinGgfv0CGV9NsSPBNZ72+zU3bCJcZSRHbnzH0d2w== X-Received: by 2002:a05:600c:6016:b0:3d3:3c93:af5e with SMTP id az22-20020a05600c601600b003d33c93af5emr31066910wmb.35.1672747518312; Tue, 03 Jan 2023 04:05:18 -0800 (PST) Received: from [192.168.0.5] (ip-109-43-177-55.web.vodafone.de. [109.43.177.55]) by smtp.gmail.com with ESMTPSA id j34-20020a05600c1c2200b003d98438a43asm32889533wms.34.2023.01.03.04.05.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jan 2023 04:05:16 -0800 (PST) Message-ID: Date: Tue, 3 Jan 2023 13:05:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 01/10] ccid-card-emulated: fix cast warning/error Content-Language: en-US To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: Laurent Vivier , Eric Blake , Beraldo Leal , Wainer dos Santos Moschetta , Gerd Hoffmann , Stefan Weil , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Paolo Bonzini , Markus Armbruster , =?UTF-8?Q?Alex_Benn=c3=a9e?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , "Dr. David Alan Gilbert" , QEMU Trivial References: <20230103110814.3726795-1-marcandre.lureau@redhat.com> <20230103110814.3726795-2-marcandre.lureau@redhat.com> From: Thomas Huth In-Reply-To: <20230103110814.3726795-2-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -58 X-Spam_score: -5.9 X-Spam_bar: ----- X-Spam_report: (-5.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.103, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 03/01/2023 12.08, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > ../hw/usb/ccid-card-emulated.c: In function 'handle_apdu_thread': > ../hw/usb/ccid-card-emulated.c:251:24: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > 251 | assert((unsigned long)event > 1000); > > Signed-off-by: Marc-André Lureau > --- > hw/usb/ccid-card-emulated.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c > index ee41a81801..c328660075 100644 > --- a/hw/usb/ccid-card-emulated.c > +++ b/hw/usb/ccid-card-emulated.c > @@ -248,7 +248,7 @@ static void *handle_apdu_thread(void* arg) > WITH_QEMU_LOCK_GUARD(&card->vreader_mutex) { > while (!QSIMPLEQ_EMPTY(&card->guest_apdu_list)) { > event = QSIMPLEQ_FIRST(&card->guest_apdu_list); > - assert((unsigned long)event > 1000); > + assert(event != NULL); > QSIMPLEQ_REMOVE_HEAD(&card->guest_apdu_list, entry); > if (event->p.data.type != EMUL_GUEST_APDU) { > DPRINTF(card, 1, "unexpected message in handle_apdu_thread\n"); Reviewed-by: Thomas Huth