From: "Cédric Le Goater" <clg@kaod.org>
To: "Cédric Le Goater" <clg@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Jamin Lin <jamin_lin@aspeedtech.com>,
Kane Chen <kane_chen@aspeedtech.com>
Subject: Re: [PATCH v2 0/3] aspeed: Improve error handling and fix DMA issues
Date: Mon, 23 Mar 2026 14:21:20 +0100 [thread overview]
Message-ID: <acd3bbe2-894b-4831-ae44-c2973f8199af@kaod.org> (raw)
In-Reply-To: <20260323125545.577653-1-clg@redhat.com>
On 3/23/26 13:55, Cédric Le Goater wrote:
> Hello,
>
> This series addresses several error handling issues in Aspeed device
> models that could lead to guest-triggerable denial of service or
> incorrect behavior.
>
> The first two patches improve DMA error handling by properly
> propagating memory transaction errors to the guest. The aspeed_smc
> patch converts memory operations to use read/write_with_attrs to
> return MEMTX_ERROR on invalid conditions, while the ftgmac100 patch
> checks DMA operation return values.
>
> The third patch fixes an incorrect assertion in the aspeed_i2c model
> that could be triggered when firmware uses the RX_BUF_LEN_W1T bit to
> program DMA length fields separately, which is valid per the Aspeed
> datasheet.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3335
> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3315
>
> Thanks,
>
> C.
>
> Changes in v2:
>
> - v1 was taking into account patch :
> https://lore.kernel.org/all/20260224065556.3847942-14-jamin_lin@aspeedtech.com
> Rebased on upstream
>
> Cédric Le Goater (3):
> hw/ssi/aspeed_smc: Convert mem ops to read/write_with_attrs for error
> handling
> ftgmac100: Improve DMA error handling
> hw/i2c/aspeed_i2c: Remove assert
>
> hw/i2c/aspeed_i2c.c | 1 -
> hw/net/ftgmac100.c | 10 +++++++--
> hw/ssi/aspeed_smc.c | 49 ++++++++++++++++++++++++++-------------------
> 3 files changed, 36 insertions(+), 24 deletions(-)
>
Applied to aspeed-next.
Thanks,
C.
prev parent reply other threads:[~2026-03-23 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 12:55 [PATCH v2 0/3] aspeed: Improve error handling and fix DMA issues Cédric Le Goater
2026-03-23 12:55 ` [PATCH v2 1/3] hw/ssi/aspeed_smc: Convert mem ops to read/write_with_attrs for error handling Cédric Le Goater
2026-03-23 12:55 ` [PATCH v2 2/3] ftgmac100: Improve DMA " Cédric Le Goater
2026-03-24 14:45 ` Michael Tokarev
2026-03-24 14:49 ` Cédric Le Goater
2026-03-23 12:55 ` [PATCH v2 3/3] hw/i2c/aspeed_i2c: Remove assert Cédric Le Goater
2026-03-23 13:21 ` Cédric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acd3bbe2-894b-4831-ae44-c2973f8199af@kaod.org \
--to=clg@kaod.org \
--cc=clg@redhat.com \
--cc=jamin_lin@aspeedtech.com \
--cc=kane_chen@aspeedtech.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox