From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 695FAC433EF for ; Wed, 2 Feb 2022 03:58:39 +0000 (UTC) Received: from localhost ([::1]:40976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nF6n0-0002my-3M for qemu-devel@archiver.kernel.org; Tue, 01 Feb 2022 22:58:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nF3f3-0005Ts-Kv for qemu-devel@nongnu.org; Tue, 01 Feb 2022 19:38:14 -0500 Received: from [2607:f8b0:4864:20::1031] (port=35753 helo=mail-pj1-x1031.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nF3f1-0000ct-9O for qemu-devel@nongnu.org; Tue, 01 Feb 2022 19:38:12 -0500 Received: by mail-pj1-x1031.google.com with SMTP id z14-20020a17090ab10e00b001b6175d4040so5175114pjq.0 for ; Tue, 01 Feb 2022 16:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=SXQe6Y6TC822QBKkRdNsGkB7KOJ+vGJ1ZAXPy6kuWDo=; b=W77qRgzPICz5l0Mg31UIZwe64gZcjOZ3Y6ktoIPO1sAU4ewMHuEFWnCXXeiJIWAjHe uKmkakJH0ma5mqcvyclMWQNd2wtHLk6hO7BKkkGAI/YEBFf7qv7Or//pynHuyqTc6XZG WCzTwE3Pgt9ysqvw7oZa8Gu5cf0n/5JRb41M/YECvettsnYWX9PPN0R64M+1Ns5dskss IgQPIornIF5jIb75L+ye6TbgWhBY8hfSTTKg7vRNjlRUpgG6nFFs93XWWA3E/KNbgfAu CyI2ajSYTd7F5sU7m3DVowgJAX3/lzk2+HBSpIJlUA7rrkWmEfNQIiR2QJkHb5gEWzXx xM0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=SXQe6Y6TC822QBKkRdNsGkB7KOJ+vGJ1ZAXPy6kuWDo=; b=dih3SCM0qD1ZI0NMmG3hLlh/p71N7OUbocM+C4Pt97hVoswI7Is068M0MhteqCfWHx cxtIjCuVUrdVdl3E+RnBTrhpPrBQDXRnbsJDPyG6ZxxwQVZmUbK9tJQPcCMoN6cXiePv IpbTriSjQaBymnQ8DCyPoEJSLfJKYKFttDuatokOXY/aJpfoXCkbcZZsvHB3doE+hyy2 CofwWQ2P8vDmpENkGnL1og9gBAxhhtm9L3GBSG1LDl8F1chflzua4Wh3K7ACuZRAQyil To6tGkl9266+divUA/TX+VLZbhZFSwOb3qSyeAG3WEL2XSr3GZrDcCNdBMICXj9FnQ06 h3tg== X-Gm-Message-State: AOAM530XKDWu7xJ5Mne5ZnGlXkAWflrQOUBbZT3eyD92gRaBRCAse06R 0M87ju0VkyIEwYW0JJk88cRvBw== X-Google-Smtp-Source: ABdhPJwTkyO503Qf0bEPpSwdL4Ha614/lJ78R/V+gBvnAUH2UShAci84kzLBi+6EAHuUVOVpM3l7Sg== X-Received: by 2002:a17:90b:4d84:: with SMTP id oj4mr5274554pjb.192.1643762290065; Tue, 01 Feb 2022 16:38:10 -0800 (PST) Received: from ?IPV6:2001:8003:3a49:fd00:91e3:5d6a:70ac:f94c? ([2001:8003:3a49:fd00:91e3:5d6a:70ac:f94c]) by smtp.gmail.com with ESMTPSA id me4sm3951663pjb.26.2022.02.01.16.38.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Feb 2022 16:38:09 -0800 (PST) Message-ID: Date: Wed, 2 Feb 2022 11:38:04 +1100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] target/riscv: Fix vill field write in vtype Content-Language: en-US To: LIU Zhiwei , qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20220201064601.41143-1-zhiwei_liu@c-sky.com> From: Richard Henderson In-Reply-To: <20220201064601.41143-1-zhiwei_liu@c-sky.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1031 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1031.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair.Francis@wdc.com, bin.meng@windriver.com, palmer@dabbelt.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/1/22 17:46, LIU Zhiwei wrote: > The guest should be able to set the vill bit as part of vsetvl. > > Currently we may set env->vill to 1 in the vsetvl helper, but there > is nowhere that we set it to 0, so once it transitions to 1 it's stuck > there until the system is reset. > > Signed-off-by: LIU Zhiwei > --- > target/riscv/vector_helper.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~