From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Thomas Weißschuh" <thomas@t-8ch.de>,
"Laurent Vivier" <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH v3 1/2] linux-user/elfload: test return value of getrlimit
Date: Mon, 22 Jan 2024 12:42:37 +0100 [thread overview]
Message-ID: <acf4d4c3-933e-4ea8-87f9-498cc690efbc@linaro.org> (raw)
In-Reply-To: <20240120-qemu-user-dumpable-v3-1-6aa410c933f1@t-8ch.de>
On 20/1/24 22:45, Thomas Weißschuh wrote:
> Should getrlimit() fail the value of dumpsize.rlimit_cur may not be
> initialized. Avoid reading garbage data by checking the return value of
> getrlimit.
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
> ---
> linux-user/elfload.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-01-22 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 21:45 [PATCH v3 0/2] linux-user: two fixes to coredump generation Thomas Weißschuh
2024-01-20 21:45 ` [PATCH v3 1/2] linux-user/elfload: test return value of getrlimit Thomas Weißschuh
2024-01-22 11:42 ` Philippe Mathieu-Daudé [this message]
2024-01-20 21:45 ` [PATCH v3 2/2] linux-user/elfload: check PR_GET_DUMPABLE before creating coredump Thomas Weißschuh
2024-01-22 11:41 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acf4d4c3-933e-4ea8-87f9-498cc690efbc@linaro.org \
--to=philmd@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thomas@t-8ch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).