From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3Lca-00053u-NL for qemu-devel@nongnu.org; Thu, 19 May 2016 06:56:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3LcV-0006VZ-NU for qemu-devel@nongnu.org; Thu, 19 May 2016 06:56:03 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:36061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3LcU-0006VV-Nu for qemu-devel@nongnu.org; Thu, 19 May 2016 06:55:59 -0400 Received: by mail-wm0-x242.google.com with SMTP id w143so19860866wmw.3 for ; Thu, 19 May 2016 03:55:58 -0700 (PDT) Sender: Paolo Bonzini References: <1463589381-66853-1-git-send-email-pbonzini@redhat.com> <573D3B5D.4040701@redhat.com> From: Paolo Bonzini Message-ID: Date: Thu, 19 May 2016 12:55:45 +0200 MIME-Version: 1.0 In-Reply-To: <573D3B5D.4040701@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH CFT v4 00/52] NEED_CPU_H / cpu.h / hw/hw.h cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: Cornelia Huck On 19/05/2016 06:04, Thomas Huth wrote: > On 18.05.2016 18:36, Paolo Bonzini wrote: >> This series removes usage of NEED_CPU_H from several central >> include files in QEMU, most notably hw/hw.h and qemu-common.h. >> Definitions conditional on NEED_CPU_H remain only in disas/disas.h, >> exec/gdbstub.h, exec/helper-head.h and exec/log.h. >> >> The interesting patches are interspersed with other miscellaenous >> cleanups that I won't really dwell on in the cover letter; the main >> changes are: >> >> - make sure that target-independent code can access QOM objects >> for the CPU through an opaque type. > > There still seems to be some target-specific code in some of the > cpu-qom.h headers: > > $ grep -r TARGET_ target-*/cpu-qom.h > target-i386/cpu-qom.h:#ifdef TARGET_X86_64 > target-mips/cpu-qom.h:#ifdef TARGET_MIPS64 > target-ppc/cpu-qom.h:#ifdef TARGET_PPC64 > target-ppc/cpu-qom.h:#elif defined(TARGET_PPCEMB) > target-ppc/cpu-qom.h:#if defined(TARGET_PPC64) > target-ppc/cpu-qom.h:#endif /* defined(TARGET_PPC64) */ > target-sparc/cpu-qom.h:#ifdef TARGET_SPARC64 > > This will mainly affect the *_CPU_CLASS macros ... should these macros > now also be moved to target-*/cpu.h instead? Probably, together with X86_CPU. A separate patch though. Thanks, Paolo > [...] >> As before, I would appreciate people compile-testing it on PPC. It should >> fix all the problems reported previously. The changes are available in >> the git repository at git://github.com/bonzini/qemu.git, branch need-cpu-h > > I've just re-checked that branch, and now it compiles fine for me on PPC. > > Thomas >