From: Eric Farman <farman@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH] docs/s390x: fix vfio-ccw type
Date: Fri, 17 Jul 2020 06:12:16 -0400 [thread overview]
Message-ID: <ad1ee483-78c8-d017-7c20-040a416a4bd7@linux.ibm.com> (raw)
In-Reply-To: <20200716145031.771476-1-cohuck@redhat.com>
On 7/16/20 10:50 AM, Cornelia Huck wrote:
> Fix the type name in the mdevctl example.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Yup, that is backwards.
Reviewed-by: Eric Farman <farman@linux.ibm.com>
> ---
>
> I always seem to get this one wrong, and mdevctl does not complain until
> it wants to start the device...
>
> ---
> docs/system/s390x/vfio-ccw.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/system/s390x/vfio-ccw.rst b/docs/system/s390x/vfio-ccw.rst
> index 8f65442c0f56..41e0bad5b489 100644
> --- a/docs/system/s390x/vfio-ccw.rst
> +++ b/docs/system/s390x/vfio-ccw.rst
> @@ -29,7 +29,7 @@ automatically, use
>
> [root@host ~]# driverctl -b css set-override 0.0.0313 vfio_ccw
> [root@host ~]# mdevctl define -u 7e270a25-e163-4922-af60-757fc8ed48c6 \
> - -p 0.0.0313 -t vfio-ccw_io -a
> + -p 0.0.0313 -t vfio_ccw-io -a
>
> If using ``mdevctl`` is not possible or wanted, follow the manual procedure
> below.
>
next prev parent reply other threads:[~2020-07-17 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 14:50 [PATCH] docs/s390x: fix vfio-ccw type Cornelia Huck
2020-07-17 10:12 ` Eric Farman [this message]
2020-07-17 13:53 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad1ee483-78c8-d017-7c20-040a416a4bd7@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).