From: Thomas Huth <thuth@redhat.com>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH v2 4/4] s390x/tcg: Ignore register content if b1/b2 is zero when handling EXECUTE
Date: Sun, 10 Jan 2021 11:11:11 +0100 [thread overview]
Message-ID: <ad22e887-45b2-4ca1-446e-7b84329cda89@redhat.com> (raw)
In-Reply-To: <20210108132049.8501-5-david@redhat.com>
On 08/01/2021 14.20, David Hildenbrand wrote:
> In our EXECUTE fast path, we have to ignore the content of r0, if
> specified by b1 or b2.
>
> Fixes: d376f123c7de ("target/s390x: Re-implement a few EXECUTE target insns directly")
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/mem_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
> index 0108611cc9..1901e9dfc7 100644
> --- a/target/s390x/mem_helper.c
> +++ b/target/s390x/mem_helper.c
> @@ -2473,8 +2473,8 @@ void HELPER(ex)(CPUS390XState *env, uint32_t ilen, uint64_t r1, uint64_t addr)
> uint32_t d1 = extract64(insn, 32, 12);
> uint32_t b2 = extract64(insn, 28, 4);
> uint32_t d2 = extract64(insn, 16, 12);
> - uint64_t a1 = wrap_address(env, env->regs[b1] + d1);
> - uint64_t a2 = wrap_address(env, env->regs[b2] + d2);
> + uint64_t a1 = wrap_address(env, (b1 ? env->regs[b1] : 0) + d1);
> + uint64_t a2 = wrap_address(env, (b2 ? env->regs[b2] : 0) + d2);
Right, "B" fields need special handling.
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-01-10 10:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 13:20 [PATCH v2 0/4] s390x/tcg: fix booting Linux kernels compiled with clang-11 and clang-12 David Hildenbrand
2021-01-08 13:20 ` [PATCH v2 1/4] s390x/tcg: Fix ALGSI David Hildenbrand
2021-01-08 19:33 ` Richard Henderson
2021-01-08 13:20 ` [PATCH v2 2/4] s390x/tcg: Fix RISBHG David Hildenbrand
2021-01-08 19:38 ` Richard Henderson
2021-01-08 13:20 ` [PATCH v2 3/4] s390x/tcg: Only ignore content in r0 when specified via "b" or "x" David Hildenbrand
2021-01-08 19:43 ` Richard Henderson
2021-01-08 13:20 ` [PATCH v2 4/4] s390x/tcg: Ignore register content if b1/b2 is zero when handling EXECUTE David Hildenbrand
2021-01-08 19:47 ` Richard Henderson
2021-01-10 10:11 ` Thomas Huth [this message]
2021-01-08 19:00 ` [PATCH v2 0/4] s390x/tcg: fix booting Linux kernels compiled with clang-11 and clang-12 Nick Desaulniers via
2021-01-08 19:21 ` Guenter Roeck
2021-01-11 9:14 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad22e887-45b2-4ca1-446e-7b84329cda89@redhat.com \
--to=thuth@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).