From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Alexey Kirillov <lekiravi@yandex-team.ru>
Cc: qemu-trivial@nongnu.org,
David Edmondson <david.edmondson@oracle.com>,
qemu-devel@nongnu.org, yc-core@yandex-team.ru
Subject: Re: [PATCH 1/1] configure: fix incorrect have_keyring check
Date: Mon, 13 Jul 2020 11:00:24 +0200 [thread overview]
Message-ID: <ad2b3d6a-701a-e867-5d79-5c19ba2a3985@redhat.com> (raw)
In-Reply-To: <20200713085528.5608-1-lekiravi@yandex-team.ru>
Hi Alexey,
On 7/13/20 10:55 AM, Alexey Kirillov wrote:
> In some shells, we can't use == sign (as example, in dash).
>
> Signed-off-by: Alexey Kirillov <lekiravi@yandex-team.ru>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 31e2ddbf28..f65914f98f 100755
> --- a/configure
> +++ b/configure
> @@ -6486,7 +6486,7 @@ EOF
> fi
> if test "$secret_keyring" != "no"
> then
> - if test "$have_keyring" == "yes"
> + if test "$have_keyring" = "yes"
> then
> secret_keyring=yes
> else
>
Thanks, but David already sent the same fix:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg713765.html
It should be merged in today or tomorrow via Alex Bennée tree.
prev parent reply other threads:[~2020-07-13 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 8:55 [PATCH 1/1] configure: fix incorrect have_keyring check Alexey Kirillov
2020-07-13 9:00 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad2b3d6a-701a-e867-5d79-5c19ba2a3985@redhat.com \
--to=philmd@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=lekiravi@yandex-team.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).