* [PATCH 1/1] configure: fix incorrect have_keyring check
@ 2020-07-13 8:55 Alexey Kirillov
2020-07-13 9:00 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Kirillov @ 2020-07-13 8:55 UTC (permalink / raw)
Cc: qemu-trivial, qemu-devel, yc-core
In some shells, we can't use == sign (as example, in dash).
Signed-off-by: Alexey Kirillov <lekiravi@yandex-team.ru>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 31e2ddbf28..f65914f98f 100755
--- a/configure
+++ b/configure
@@ -6486,7 +6486,7 @@ EOF
fi
if test "$secret_keyring" != "no"
then
- if test "$have_keyring" == "yes"
+ if test "$have_keyring" = "yes"
then
secret_keyring=yes
else
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] configure: fix incorrect have_keyring check
2020-07-13 8:55 [PATCH 1/1] configure: fix incorrect have_keyring check Alexey Kirillov
@ 2020-07-13 9:00 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-13 9:00 UTC (permalink / raw)
To: Alexey Kirillov; +Cc: qemu-trivial, David Edmondson, qemu-devel, yc-core
Hi Alexey,
On 7/13/20 10:55 AM, Alexey Kirillov wrote:
> In some shells, we can't use == sign (as example, in dash).
>
> Signed-off-by: Alexey Kirillov <lekiravi@yandex-team.ru>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 31e2ddbf28..f65914f98f 100755
> --- a/configure
> +++ b/configure
> @@ -6486,7 +6486,7 @@ EOF
> fi
> if test "$secret_keyring" != "no"
> then
> - if test "$have_keyring" == "yes"
> + if test "$have_keyring" = "yes"
> then
> secret_keyring=yes
> else
>
Thanks, but David already sent the same fix:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg713765.html
It should be merged in today or tomorrow via Alex Bennée tree.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-13 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-13 8:55 [PATCH 1/1] configure: fix incorrect have_keyring check Alexey Kirillov
2020-07-13 9:00 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).