Re: [Qemu-devel] [PATCH] net: Allow hubports to connect to other netdevs

[Jason Wang <jasowang@redhat.com>]

On 2018年01月16日 02:06, Thomas Huth wrote:
> On 15.01.2018 18:36, Thomas Huth wrote:
>> On 15.01.2018 08:40, Jason Wang wrote:
> [...]
>>> And since it was a hub, do we need to send to its netdev too inside
>>> net_hub_receive()?
>> I currently don't think so, but I'll check again...
> OK, I now think we're definitely fine here. The check is really just
> there to make sure that we do not send the packet back to the same
> sender. And I've checked with a command line like this that network
> traffic (TFTP booting in this case) works as expected:
>
> qemu-system-ppc64 -vga none -nographic \
>   -netdev user,id=s1,tftp=/path/to/tftpdir,bootfile=ppc64.img \
>   -netdev hubport,hubid=1,id=h1,netdev=s1  \
>   -netdev hubport,hubid=1,id=h3 -device virtio-net-pci,netdev=h3 \
>   -boot n -object filter-dump,id=f1,netdev=s1,file=/tmp/dump.dat
>
> Both, the behaviour of the TFTP boot in the guest and the wireshark dump
> looked fine, there were no missing packets here.
>
>   Thomas

Right, I think I misread the command parameters.

Thanks