From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emDc1-0001Gs-TB for qemu-devel@nongnu.org; Thu, 15 Feb 2018 02:05:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emDc1-00060e-49 for qemu-devel@nongnu.org; Thu, 15 Feb 2018 02:05:45 -0500 References: <20180215042900.16078-1-f4bug@amsat.org> <20180215042900.16078-12-f4bug@amsat.org> From: Thomas Huth Message-ID: Date: Thu, 15 Feb 2018 08:05:39 +0100 MIME-Version: 1.0 In-Reply-To: <20180215042900.16078-12-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH 11/30] hw/s390x: use the BYTE-based definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: David Hildenbrand , Cornelia Huck , Alexander Graf , Christian Borntraeger , "open list:S390" , Richard Henderson On 15.02.2018 05:28, Philippe Mathieu-Daud=C3=A9 wrote: > It ease code review, unit is explicit. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/s390x/sclp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c > index 276972b59f..8537aa2688 100644 > --- a/hw/s390x/sclp.c > +++ b/hw/s390x/sclp.c > @@ -526,8 +526,8 @@ static void sclp_realize(DeviceState *dev, Error **= errp) > =20 > ret =3D s390_set_memory_limit(machine->maxram_size, &hw_limit); > if (ret =3D=3D -E2BIG) { > - error_setg(&err, "host supports a maximum of %" PRIu64 " GB", > - hw_limit >> 30); > + error_setg(&err, "host supports a maximum of %llu GB", > + hw_limit / G_BYTE); > } else if (ret) { > error_setg(&err, "setting the guest size failed"); > } Reviewed-by: Thomas Huth