From: BALATON Zoltan <balaton@eik.bme.hu>
To: qemu-devel@nongnu.org
Cc: "Gerd Hoffmann" <kraxel@redhat.com>,
marcandre.lureau@redhat.com,
"Chad Jablonski" <chad@jablonski.xyz>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v6 2/8] ati-vga: Also switch mode on HW cursor enable bit change
Date: Sat, 21 Mar 2026 17:30:12 +0100 (CET) [thread overview]
Message-ID: <ad3f415749178984c764f4ba810c663d1299ddfd.1774110169.git.balaton@eik.bme.hu> (raw)
In-Reply-To: <cover.1774110169.git.balaton@eik.bme.hu>
This does nothing for most drivers but works around issue and fixes
output with the Solaris R128 driver that only sets display parameters
after enabling CRT controller which we would miss otherwise.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Tested-by: Chad Jablonski <chad@jablonski.xyz>
Reviewed-by: Chad Jablonski <chad@jablonski.xyz>
---
hw/display/ati.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/ati.c b/hw/display/ati.c
index c165434938..8286f67c1c 100644
--- a/hw/display/ati.c
+++ b/hw/display/ati.c
@@ -632,6 +632,7 @@ static void ati_mm_write(void *opaque, hwaddr addr,
ati_reg_write_offs(&s->regs.crtc_gen_cntl,
addr - CRTC_GEN_CNTL, data, size);
if ((val & CRTC2_CUR_EN) != (s->regs.crtc_gen_cntl & CRTC2_CUR_EN)) {
+ ati_vga_switch_mode(s);
if (s->cursor_guest_mode) {
s->vga.force_shadow = !!(s->regs.crtc_gen_cntl & CRTC2_CUR_EN);
} else {
--
2.41.3
next prev parent reply other threads:[~2026-03-21 16:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 16:30 [PATCH v6 0/8] ati-vga fixes BALATON Zoltan
2026-03-21 16:30 ` [PATCH v6 1/8] ati-vga: Fix colors when frame buffer endianness does not match host BALATON Zoltan
2026-03-21 16:30 ` BALATON Zoltan [this message]
2026-03-21 16:30 ` [PATCH v6 3/8] ati-vga: Do not add crtc offset to src and dst data address BALATON Zoltan
2026-03-21 16:30 ` [PATCH v6 4/8] ati-vga: Avoid warnings about sign extension BALATON Zoltan
2026-03-21 16:30 ` [PATCH v6 5/8] ati-vga: Fix display updates in non-32 bit modes BALATON Zoltan
2026-03-21 16:30 ` [PATCH v6 6/8] ati-vga: Add work around for fuloong2e BALATON Zoltan
2026-03-21 16:30 ` [PATCH v6 7/8] ati-vga: Simplify pointer image handling BALATON Zoltan
2026-03-23 12:21 ` Philippe Mathieu-Daudé
2026-03-23 12:25 ` Philippe Mathieu-Daudé
2026-03-23 13:39 ` BALATON Zoltan
2026-03-23 13:38 ` BALATON Zoltan
2026-03-24 14:17 ` Chad Jablonski
2026-03-24 14:49 ` BALATON Zoltan
2026-03-25 13:10 ` Chad Jablonski
2026-03-21 16:30 ` [PATCH v6 8/8] ati-vga: Make sure hardware cursor data is within vram BALATON Zoltan
2026-03-24 13:29 ` Chad Jablonski
2026-03-23 12:01 ` [PATCH v6 0/8] ati-vga fixes BALATON Zoltan
2026-03-24 13:38 ` Michael Tokarev
2026-03-24 14:31 ` Michael Tokarev
2026-03-24 14:39 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad3f415749178984c764f4ba810c663d1299ddfd.1774110169.git.balaton@eik.bme.hu \
--to=balaton@eik.bme.hu \
--cc=chad@jablonski.xyz \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox