From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26FF4C433E0 for ; Tue, 9 Mar 2021 05:09:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81C34651D3 for ; Tue, 9 Mar 2021 05:09:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81C34651D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJUc8-0002SR-Hx for qemu-devel@archiver.kernel.org; Tue, 09 Mar 2021 00:09:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJUbZ-00022c-4S for qemu-devel@nongnu.org; Tue, 09 Mar 2021 00:08:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lJUbW-0005Mv-0q for qemu-devel@nongnu.org; Tue, 09 Mar 2021 00:08:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615266499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ux7ceELQ0dqaESN9MywBZLqiGHpjOo7CGCJYDYmDbKk=; b=I7ys03z2zsaWmraHLHU7IwtqF7aexL1/WshiNE5NT1BX/XlWlAuFLu8zPwbSkTUKQ8lmWY k/QYK1T6FYQtMAl4YAnQ8pvjGlSJmQVTeRHxSWKFpvDX9J8ygcCHTNmct346yCUFqsCEzg vciqnLqTNWP3L+cdM1UmgcHsejcABhI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-411-p2f4YoJmMaG0CElTAm8bKA-1; Tue, 09 Mar 2021 00:08:17 -0500 X-MC-Unique: p2f4YoJmMaG0CElTAm8bKA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5F965881276; Tue, 9 Mar 2021 05:08:15 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-53.ams2.redhat.com [10.36.112.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9703F1A8A0; Tue, 9 Mar 2021 05:08:13 +0000 (UTC) Subject: Re: [PATCH v2] FreeBSD: Upgrade to 12.2 release To: Warner Losh , Roman Bolshakov References: <20210307155654.993-1-imp@bsdimp.com> <20210307155654.993-2-imp@bsdimp.com> From: Thomas Huth Message-ID: Date: Tue, 9 Mar 2021 06:08:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel P. Berrange" , =?UTF-8?Q?Alex_Benn=c3=a9e?= , QEMU Developers , Stefan Weil Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 08/03/2021 20.57, Warner Losh wrote: > > > On Mon, Mar 8, 2021 at 12:51 PM Warner Losh > wrote: > > > > On Mon, Mar 8, 2021 at 8:46 AM Roman Bolshakov > wrote: > > > > 8 марта 2021 г., в 18:41, Thomas Huth > написал(а): > > > > On 08/03/2021 16.26, Warner Losh wrote: > >> On Mon, Mar 8, 2021 at 6:30 AM Thomas Huth >> wrote: > >>    On 07/03/2021 16.56, Warner Losh wrote: > >>     > FreeBSD 12.1 has reached end of life. Use 12.2 instead so > that FreeBSD's > >>     > project's packages will work.  Update which timezone to > pick. Work > >>    around a QEMU > >>     > bug that incorrectly raises an exception on a CRC32 > instruction with > >>    the FPU > >>     > disabled.  The qemu bug is described here: > >>     > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg784158.html > > >> > > > >>     > > >>     > Signed-off-by: Warner Losh >> > >>     > > >>     > --- > >>     >   tests/vm/freebsd | 14 +++++++++----- > >>     >   1 file changed, 9 insertions(+), 5 deletions(-) > >>    I gave this a try, but it's currently failing in the unit tests: > >>    Running test test-crypto-tlscredsx509 > >>    ** (tests/test-crypto-tlscredsx509:9999): CRITICAL **: > 12:56:35.157: Failed > >>    to sign certificate ASN1 parser: Value is not valid. > >>    ERROR test-crypto-tlscredsx509 - Bail out! FATAL-CRITICAL: > Failed to sign > >>    certificate ASN1 parser: Value is not valid. > >>    gmake: *** [Makefile.mtest:576: run-test-70] Error 1 > >>    gmake: *** Waiting for unfinished jobs.... > >>    Running test test-crypto-tlssession > >>    ** (tests/test-crypto-tlssession:10002): CRITICAL **: > 12:56:35.288: Failed > >>    to sign certificate ASN1 parser: Value is not valid. > >>    ERROR test-crypto-tlssession - Bail out! FATAL-CRITICAL: > Failed to sign > >>    certificate ASN1 parser: Value is not valid. > >> That's totally unrelated to my change. Was it failing before? > What environment was it failing in because it all seemed to work for > me... > > > > It's been a while since I last ran "make vm-build-freebsd", so I > can't really tell whether the problem was already there before ... > when I now try to run it without your patch, it fails for me, too, > but rather due to FreeBSD 12.1 being out of service instead. > > > >>    I guess it's the same problem as: > >> > https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06750.html > > >> > > > >>    ... so this would require a bug fix in the libtasn of FreeBSD > first? See: > >> https://gitlab.com/gnutls/libtasn1/-/merge_requests/71 > > >>    > > >>  Is this on the host that built qemu, or inside the VM or where > exactly? > > > > It's inside the VM ... I assume the libtasn there has the same > bug as the one on macOS? > > > > The gnutls failures on macOS and FreeBSD (with clang as main > compiler) won’t happen only if libtasn1 from master is used. > Otherwise libtasn1 has to be compiled with -O1/-O0. > > > Forgive my ignorance... > > Does this come from a submodule? From something I've built and installed > on my FreeBSD host? Or something that's installed into the FreeBSD guest > > > ah, it's inside the guest. Yes, IIUC it's the pre-installed libtasn1 in the guest, and the problem likely occurs just now since the clang that has been used to compile the library has been updated, too? Anyway, can you reproduce the issue? If so, could you please file a bug ticket against libtasn1 there, so that it gets fixed? (sorry, I don't have any clue about the FreeBSD process here) Thomas