From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgp4h-0002D5-Rq for qemu-devel@nongnu.org; Mon, 05 Sep 2016 04:16:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgp4d-0000fO-Hu for qemu-devel@nongnu.org; Mon, 05 Sep 2016 04:16:14 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:36287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgp4d-0000fK-Aq for qemu-devel@nongnu.org; Mon, 05 Sep 2016 04:16:11 -0400 Received: by mail-wm0-x241.google.com with SMTP id l65so4237358wmf.3 for ; Mon, 05 Sep 2016 01:16:11 -0700 (PDT) Sender: Paolo Bonzini References: <1473061514-3619-1-git-send-email-ashijeetacharya@gmail.com> <461a1f33-c9c0-afe3-a0bd-6e059942dab0@redhat.com> From: Paolo Bonzini Message-ID: Date: Mon, 5 Sep 2016 10:16:10 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya Cc: quintela@redhat.com, armbru@redhat.com, QEMU Developers , amit.shah@redhat.com, lcapitulino@redhat.com, "dgilbert@redhat.com" On 05/09/2016 10:11, Ashijeet Acharya wrote: > > > Include migrate_set_speed and migrate_set_downtime inside > > > migrate_set_parameters respectively for setting maximum migration > > > speed and expected downtime parameters. Also add the query part for > > > both in qmp and hmp qemu control interfaces. > > > > > > Signed-off-by: Ashijeet Acharya > > > > You cannot break backwards compatibility for everyone that is using > > those commands, sorry. > > So should I keep the old commands too and add the new ones anyway for > the query part? You do not need query for the old ones, but you can indeed add support for speed and downtime in migrate-set-parameters and MigrationParameters. (Note: I'm not a migration maintainer, so they might say something else). Paolo > The old ones will also be modified for query. So we will have > compatibility as well as the > query.