From: Richard Henderson <rth@twiddle.net>
To: Stafford Horne <shorne@gmail.com>,
QEMU Development <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target/openrisc: Support non-busy idle state using PMR SPR
Date: Sat, 29 Apr 2017 11:32:52 +0200 [thread overview]
Message-ID: <ad616d4e-a6fc-c8e3-9698-ad57762ac035@twiddle.net> (raw)
In-Reply-To: <20170428211018.2927-1-shorne@gmail.com>
On 04/28/2017 11:10 PM, Stafford Horne wrote:
> + raise_exception(cpu, EXCP_HLT);
One minor tweak -- EXCP_HALTED.
HLT is, in theory, i386 specific. Not that you'd have noticed a difference.
FWIW, I've just found the same error in target/alpha.
Otherwise,
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2017-04-29 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 21:10 [Qemu-devel] [PATCH] target/openrisc: Support non-busy idle state using PMR SPR Stafford Horne
2017-04-29 9:32 ` Richard Henderson [this message]
2017-04-29 10:13 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad616d4e-a6fc-c8e3-9698-ad57762ac035@twiddle.net \
--to=rth@twiddle.net \
--cc=qemu-devel@nongnu.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).