From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Subject: Re: [PATCH 4/4] hw/misc/macio: Return bool from functions taking errp
Date: Wed, 18 Jan 2023 08:19:01 +0100 [thread overview]
Message-ID: <ad71b960-9e4f-7cc7-f0f5-081fccee7913@linaro.org> (raw)
In-Reply-To: <bfce0751e82b031f5e6fb3c32cfbce6325434400.1674001242.git.balaton@eik.bme.hu>
On 18/1/23 01:32, BALATON Zoltan wrote:
> Use the convention to return bool from functions which take an error
> pointer which allows for callers to pass through their error pointer
> without needing a local.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/misc/macio/macio.c | 62 +++++++++++++++++--------------------------
> 1 file changed, 25 insertions(+), 37 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-01-18 7:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 0:32 [PATCH 0/4] Misc macio clean ups BALATON Zoltan
2023-01-18 0:32 ` [PATCH 1/4] hw/misc/macio: Avoid some QOM casts BALATON Zoltan
2023-01-18 7:16 ` Philippe Mathieu-Daudé
2023-01-22 18:14 ` Mark Cave-Ayland
2023-01-18 0:32 ` [PATCH 2/4] hw/misc/macio: Rename sysbus_dev to sbd for consistency and brevity BALATON Zoltan
2023-01-18 7:16 ` Philippe Mathieu-Daudé
2023-01-22 18:15 ` Mark Cave-Ayland
2023-01-18 0:32 ` [PATCH 3/4] hw/misc/macio: Remove some single use local variables BALATON Zoltan
2023-01-18 7:17 ` Philippe Mathieu-Daudé
2023-01-22 18:16 ` Mark Cave-Ayland
2023-01-18 0:32 ` [PATCH 4/4] hw/misc/macio: Return bool from functions taking errp BALATON Zoltan
2023-01-18 7:19 ` Philippe Mathieu-Daudé [this message]
2023-02-01 22:44 ` Mark Cave-Ayland
2023-02-01 23:54 ` BALATON Zoltan
2023-02-01 23:32 ` [PATCH 0/4] Misc macio clean ups Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad71b960-9e4f-7cc7-f0f5-081fccee7913@linaro.org \
--to=philmd@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).