From: Laurent Vivier <laurent@vivier.eu>
To: Thomas Huth <thuth@redhat.com>, Yi Wang <wang.yi59@zte.com.cn>,
qemu-devel@nongnu.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
wang.liang82@zte.com.cn, Liao Pingfang <liao.pingfang@zte.com.cn>,
Qemu-block <qemu-block@nongnu.org>,
xue.zhihong@zte.com.cn
Subject: Re: [PATCH 08/12] block/vmdk: Remove superfluous breaks
Date: Tue, 1 Sep 2020 08:37:37 +0200 [thread overview]
Message-ID: <ad7366a2-64e9-c088-d988-abdecba8067d@vivier.eu> (raw)
In-Reply-To: <ea32b527-7d78-1c7a-a2a2-30ffa2a9e528@redhat.com>
Le 13/07/2020 à 11:36, Thomas Huth a écrit :
> On 13/07/2020 11.05, Yi Wang wrote:
>> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>>
>> Remove superfluous breaks, as there is a "return" before them.
>>
>> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> block/vmdk.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/block/vmdk.c b/block/vmdk.c
>> index 28cec50..8f222e3 100644
>> --- a/block/vmdk.c
>> +++ b/block/vmdk.c
>> @@ -1053,14 +1053,11 @@ static int vmdk_open_sparse(BlockDriverState *bs, BdrvChild *file, int flags,
>> switch (magic) {
>> case VMDK3_MAGIC:
>> return vmdk_open_vmfs_sparse(bs, file, flags, errp);
>> - break;
>> case VMDK4_MAGIC:
>> return vmdk_open_vmdk4(bs, file, flags, options, errp);
>> - break;
>> default:
>> error_setg(errp, "Image not in VMDK format");
>> return -EINVAL;
>> - break;
>> }
>> }
>>
>>
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
prev parent reply other threads:[~2020-09-01 6:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 9:05 [PATCH 08/12] block/vmdk: Remove superfluous breaks Yi Wang
2020-07-13 9:36 ` Thomas Huth
2020-09-01 6:37 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad7366a2-64e9-c088-d988-abdecba8067d@vivier.eu \
--to=laurent@vivier.eu \
--cc=liao.pingfang@zte.com.cn \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).