From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, Claudio Fontana <cfontana@suse.de>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: meson, NEED_CPU_H, CONFIG_TCG and tests/
Date: Fri, 19 Feb 2021 17:04:52 +0100 [thread overview]
Message-ID: <ad889877-fc1c-9346-3cc5-4d177295f076@redhat.com> (raw)
In-Reply-To: <a9f6fbf7-fb29-eca6-44f0-91381e8b3084@redhat.com>
On 19/02/21 14:30, Thomas Huth wrote:
>> But how could tests see this?
>
> The test are generic, not target-specific code, so they can not see
> things like NEED_CPU_H, of course.
>
> But CONFIG_TCG seems to be defined in config-host.h, so you should be
> able to use that define, shouldn't you?
Yes, CONFIG_TCG is defined in config_hsot just for that reason:
tcg_arch = config_host['ARCH']
if not get_option('tcg').disabled()
...
accelerators += 'CONFIG_TCG'
config_host += { 'CONFIG_TCG': 'y' }
endif
It's ugly, but I kept it that way when moving accelerator configuration
to Meson.
Paolo
next prev parent reply other threads:[~2021-02-19 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 13:04 meson, NEED_CPU_H, CONFIG_TCG and tests/ Claudio Fontana
2021-02-19 13:13 ` Claudio Fontana
2021-02-19 13:14 ` Philippe Mathieu-Daudé
2021-02-19 13:17 ` Claudio Fontana
2021-02-19 13:48 ` Philippe Mathieu-Daudé
2021-02-19 13:54 ` Claudio Fontana
2021-02-19 13:30 ` Thomas Huth
2021-02-19 16:04 ` Paolo Bonzini [this message]
2021-02-19 17:24 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad889877-fc1c-9346-3cc5-4d177295f076@redhat.com \
--to=pbonzini@redhat.com \
--cc=cfontana@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).