From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D290C433DB for ; Thu, 4 Mar 2021 19:54:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D692664F65 for ; Thu, 4 Mar 2021 19:54:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D692664F65 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHu3d-00075u-KE for qemu-devel@archiver.kernel.org; Thu, 04 Mar 2021 14:54:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHu22-0006E1-8Y for qemu-devel@nongnu.org; Thu, 04 Mar 2021 14:53:11 -0500 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]:52134) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHu1r-00042C-Jx for qemu-devel@nongnu.org; Thu, 04 Mar 2021 14:53:04 -0500 Received: by mail-pj1-x1029.google.com with SMTP id jx13so7281061pjb.1 for ; Thu, 04 Mar 2021 11:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=zXy9gFQPLNhKDKZB3qV0+lZKdpYYhXe9c8Wt1+fjN0o=; b=b/BHSeNjc7RU3PAhjs1t6kHIJ84j0AtiMB9T7+NBO0vPx1Zp/C/utdNbVd+A1zuSys U7TEC6yQnj4QXEx1zAIODN46tnkmTNIgisYtaksY08fr+B1C+jTzDz8h2ZQIkRDNvfrT N8raSUPfgOJ15pA400b7vbecTQAz2cKxQfPu1p7EV3IDG0KVmrRhpuk+l7YEC3zzJHZV luhfymSkd3uC//sOPyMyLPI2W0x6DM3NCowixrbQAUJ1v39J8hZVaqhVcGtltRO6t4Fi 1kbOJWnW33VbJTykPpiLLU14Jz1PTYGhxBa1Isz0j1pyebeOKc9zJZm650q6Jr1rqKxO tOgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zXy9gFQPLNhKDKZB3qV0+lZKdpYYhXe9c8Wt1+fjN0o=; b=Rg3PkwXuUcwtiEsN0khxLy5Q29Fw95FFMLE8HQkjqt4iPohuAZc4Vs44tcNPiyGDWk 49WPDbuwhAjXAVVGHUvPOKenwAGj+SnaTm9UhPShAWuoB5p3fDn8tGwCHDugqqXES0Qi sFLFvOd0j4eCjTj2lrZpAbZ+BJxUn0UbCyfNvXvmZ1pNzcGA5pCb+fNSvkLV3rVCBlg2 GfPgPtljv7oYaOaavQ+SR6p5/nyTQjqVWMcnMMUrN39z+/UaFsqT0kjRMZfdV6NwvJQU F5PVcNT6nidYgBmwFOBuiG5iop1u16nH1Ma2XjaSlIdgeceLd0vFlbQqmOLeEsKQ2FTz 19hw== X-Gm-Message-State: AOAM5338GTbvHY/E8v/qMhc19jfKcAyPPhvzWVQNA39Qb8UWALX2rwyy s273fAETCZW6hjDUQ7+unQstcnSYAlzHuQ== X-Google-Smtp-Source: ABdhPJwjvEA4WAcc7fxNVoXJeAFG+CgFAiRY3CzsZuHjDAfKfd7S1Hw998p2JNU9L7zOBGvnyN1xZg== X-Received: by 2002:a17:90a:8908:: with SMTP id u8mr5983545pjn.135.1614887575890; Thu, 04 Mar 2021 11:52:55 -0800 (PST) Received: from [192.168.1.11] ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id d124sm196319pfa.149.2021.03.04.11.52.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Mar 2021 11:52:55 -0800 (PST) Subject: Re: [PATCH 17/44] hw/misc/iotkit-sysctl: Handle SSE-300 changes to PDCM_PD_*_SENSE registers To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210219144617.4782-1-peter.maydell@linaro.org> <20210219144617.4782-18-peter.maydell@linaro.org> From: Richard Henderson Message-ID: Date: Thu, 4 Mar 2021 11:52:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210219144617.4782-18-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/19/21 6:45 AM, Peter Maydell wrote: > The sysctl PDCM_PD_*_SENSE registers control various power domains in > the system and allow the guest to configure which conditions keep a > power domain awake and what power state to use when the domain is in > a low power state. QEMU doesn't model power domains, so for us these > registers are dummy reads-as-written implementations. > > The SSE-300 has a different power domain setup, so the set of > registers is slightly different: > > Offset SSE-200 SSE-300 > --------------------------------------------------- > 0x200 PDCM_PD_SYS_SENSE PDCM_PD_SYS_SENSE > 0x204 reserved PDCM_PD_CPU0_SENSE > 0x208 reserved reserved > 0x20c PDCM_PD_SRAM0_SENSE reserved > 0x210 PDCM_PD_SRAM1_SENSE reserved > 0x214 PDCM_PD_SRAM2_SENSE PDCM_PD_VMR0_SENSE > 0x218 PDCM_PD_SRAM3_SENSE PDCM_PD_VMR1_SENSE > > Offsets 0x200 and 0x208 are the same for both, so handled in a > previous commit; here we deal with 0x204, 0x20c, 0x210, 0x214, 0x218. > > (We can safely add new lines to the SSE300 vmstate because no board > uses this device in an SSE300 yet.) > > Signed-off-by: Peter Maydell > --- Reviewed-by: Richard Henderson r~