From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Peter Krempa <pkrempa@redhat.com>,
qemu-block@nongnu.org, Thomas Huth <thuth@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
qemu-devel@nongnu.org, mreitz@redhat.com,
prasanna.kalever@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH for-2.12] gluster: Fix blockdev-add with server.N.type=unix
Date: Wed, 4 Apr 2018 13:49:37 -0500 [thread overview]
Message-ID: <add8a5a5-0ba1-fae0-05b9-e909165ef0b7@redhat.com> (raw)
In-Reply-To: <20180404183755.GI4482@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
On 04/04/2018 01:37 PM, Kevin Wolf wrote:
> Am 04.04.2018 um 20:16 hat Eric Blake geschrieben:
>> On 04/04/2018 10:54 AM, Kevin Wolf wrote:
>>
>>>>> Should we also add a deprecation warning for 'socket' and update the
>>>>> deprecation documentation, so we can start the clock ticking on getting
>>>>> rid of maintaining the back-compat glue forever?
>>>>
> We only strictly need it in introspection at the time when we remove the
> old option. But maybe it would be nicer to wait with the deprecation
> error_report() until libvirt has a chance to avoid the warning.
Makes sense - so no deprecation warning for 2.12, and the timeline for
performing a deprecation is shifted by a couple of releases after the
first time we introduce proper introspection support. Which makes this
patch fine as-is.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-04-04 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 11:08 [Qemu-devel] [PATCH for-2.12] gluster: Fix blockdev-add with server.N.type=unix Kevin Wolf
2018-04-03 13:09 ` Eric Blake
2018-04-04 15:41 ` [Qemu-devel] [Qemu-block] " Peter Krempa
2018-04-04 15:54 ` Kevin Wolf
2018-04-04 18:16 ` Eric Blake
2018-04-04 18:37 ` Kevin Wolf
2018-04-04 18:49 ` Eric Blake [this message]
2018-04-03 13:55 ` [Qemu-devel] " Jeff Cody
2018-04-03 13:55 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=add8a5a5-0ba1-fae0-05b9-e909165ef0b7@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pkrempa@redhat.com \
--cc=prasanna.kalever@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).