From: Paolo Bonzini <pbonzini@redhat.com>
To: Jie Wang <wangjie88@huawei.com>,
Michal Privoznik <mprivozn@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: eric.fangyi@huawei.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] pr-manager-helper: fix pr process been killed when reconectting
Date: Wed, 29 May 2019 11:37:09 +0200 [thread overview]
Message-ID: <ade54a00-f5e5-495f-f2d7-ba82430d6831@redhat.com> (raw)
In-Reply-To: <8600e1e3-fd24-6e07-6951-f70b7a23f703@huawei.com>
On 29/05/19 10:37, Jie Wang wrote:
> when the problem appeared:
>
> 1. qemu will initialize pr-helper and connect to it cyclically, but
> always failed because no running pr-helper process to connect.
>
> 2. libvirt will always waiting for connected event, but will never to
> start new pr-helper process because not receive disconnect event.
>
> I'm not found the best way to solve this problem, can you give me some
> suggestion?
I can't find a way that is better than your patch, either. Another
possible problem is that this could cause libvirt to spawn two helpers
if you have a race like
qemu: report DISCONNECTED
libvirt: start pr-helper #1
qemu: report DISCONNECTED
libvirt: start pr-helper #2
pr-helper #1: create socket
pr-helper #2: fail to start
But it should not be an issue since one of the two pr-helpers will clean
up after itself.
Paolo
next prev parent reply other threads:[~2019-05-29 9:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 13:06 [Qemu-devel] [PATCH] pr-manager-helper: fix pr process been killed when reconectting Jie Wang
2019-05-28 17:45 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini
2019-05-29 7:33 ` Michal Privoznik
2019-05-29 8:37 ` Jie Wang
2019-05-29 9:37 ` Paolo Bonzini [this message]
2019-05-29 9:34 ` Paolo Bonzini
2019-05-30 10:08 ` Michal Privoznik
2019-05-30 10:59 ` Paolo Bonzini
2019-06-11 13:51 ` wangjie (P)
2019-06-11 14:46 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ade54a00-f5e5-495f-f2d7-ba82430d6831@redhat.com \
--to=pbonzini@redhat.com \
--cc=eric.fangyi@huawei.com \
--cc=mprivozn@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wangjie88@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).