From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Zhao Liu" <zhao1.liu@intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Alireza Sanaee" <alireza.sanaee@huawei.com>,
"Sia Jee Heng" <jeeheng.sia@starfivetech.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH v7 RESEND 1/5] hw/core/machine: Reject thread level cache
Date: Thu, 6 Feb 2025 10:42:50 +0100 [thread overview]
Message-ID: <adfe1b26-7e5a-4ced-92c4-9d396953f197@linaro.org> (raw)
In-Reply-To: <20250110145115.1574345-2-zhao1.liu@intel.com>
On 10/1/25 15:51, Zhao Liu wrote:
> Currently, neither i386 nor ARM have real hardware support for per-
> thread cache, and there is no clear demand for this specific cache
> topology.
>
> Additionally, since ARM even can't support this special cache topology
> in device tree, it is unnecessary to support it at this moment, even
> though per-thread cache might have potential scheduling benefits for
> VMs without CPU affinity.
>
> Therefore, disable thread-level cache topology in the general machine
> part. At present, i386 has not enabled SMP cache, so disabling the
> thread parameter does not pose compatibility issues.
>
> In the future, if there is a clear demand for this feature, the correct
> approach would be to add a new control field in MachineClass.smp_props
> and enable it only for the machines that require it.
>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> Changes since Patch v6:
> * New commit to reject "thread" parameter when parse smp-cache.
> ---
> hw/core/machine-smp.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-02-06 9:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 14:51 [PATCH v7 RESEND 0/5] i386: Support SMP Cache Topology Zhao Liu
2025-01-10 14:51 ` [PATCH v7 RESEND 1/5] hw/core/machine: Reject thread level cache Zhao Liu
2025-02-06 9:42 ` Philippe Mathieu-Daudé [this message]
2025-01-10 14:51 ` [PATCH v7 RESEND 2/5] i386/cpu: Support module level cache topology Zhao Liu
2025-01-10 14:51 ` [PATCH v7 RESEND 3/5] i386/cpu: Update cache topology with machine's configuration Zhao Liu
2025-01-10 14:51 ` [PATCH v7 RESEND 4/5] i386/pc: Support cache topology in -machine for PC machine Zhao Liu
2025-01-10 14:51 ` [PATCH v7 RESEND 5/5] i386/cpu: add has_caches flag to check smp_cache configuration Zhao Liu
2025-01-15 8:46 ` [PATCH v7 RESEND 0/5] i386: Support SMP Cache Topology Michael S. Tsirkin
2025-02-05 12:32 ` Markus Armbruster
2025-02-06 9:17 ` Zhao Liu
2025-02-06 9:21 ` Zhao Liu
2025-02-19 8:59 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adfe1b26-7e5a-4ced-92c4-9d396953f197@linaro.org \
--to=philmd@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=alireza.sanaee@huawei.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=jeeheng.sia@starfivetech.com \
--cc=kvm@vger.kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).