From: "Durrant, Paul" <xadimgnik@gmail.com>
To: Jason Andryuk <jandryuk@gmail.com>, qemu-devel@nongnu.org
Cc: Eduardo Habkost <eduardo@habkost.net>,
Stefano Stabellini <sstabellini@kernel.org>,
Paul Durrant <paul@xen.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
"open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>,
Anthony Perard <anthony.perard@citrix.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] xen-hvm: Allow disabling buffer_io_timer
Date: Tue, 14 Dec 2021 05:40:57 -0800 [thread overview]
Message-ID: <adfe1c14-f773-0592-e304-d80da8380cc0@gmail.com> (raw)
In-Reply-To: <20211210193434.75566-1-jandryuk@gmail.com>
On 10/12/2021 11:34, Jason Andryuk wrote:
> commit f37f29d31488 "xen: slightly simplify bufioreq handling" hard
> coded setting req.count = 1 during initial field setup before the main
> loop. This missed a subtlety that an early exit from the loop when
> there are no ioreqs to process, would have req.count == 0 for the return
> value. handle_buffered_io() would then remove state->buffered_io_timer.
> Instead handle_buffered_iopage() is basically always returning true and
> handle_buffered_io() always re-setting the timer.
>
> Restore the disabling of the timer by introducing a new handled_ioreq
> boolean and use as the return value. The named variable will more
> clearly show the intent of the code.
>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Reviewed-by: Paul Durrant <paul@xen.org>
next prev parent reply other threads:[~2021-12-14 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 19:34 [PATCH] xen-hvm: Allow disabling buffer_io_timer Jason Andryuk
2021-12-14 13:40 ` Durrant, Paul [this message]
2022-01-26 13:43 ` Jason Andryuk
2022-01-26 13:47 ` Durrant, Paul
2022-01-26 16:43 ` Anthony PERARD via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adfe1c14-f773-0592-e304-d80da8380cc0@gmail.com \
--to=xadimgnik@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=eduardo@habkost.net \
--cc=jandryuk@gmail.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).