From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48775)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1b5Cs9-0004OZ-4P
	for qemu-devel@nongnu.org; Tue, 24 May 2016 09:59:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1b5Cs3-00082w-UR
	for qemu-devel@nongnu.org; Tue, 24 May 2016 09:59:48 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1464097151-19479-1-git-send-email-pl@kamp.de>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <ae091ece-2e70-6c45-c11e-09b489c3a78b@redhat.com>
Date: Tue, 24 May 2016 15:59:38 +0200
MIME-Version: 1.0
In-Reply-To: <1464097151-19479-1-git-send-email-pl@kamp.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] block/io: optimize bdrv_co_pwritev for
 small requests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com



On 24/05/2016 15:39, Peter Lieven wrote:
>          bytes += offset & (align - 1);
>          offset = offset & ~(align - 1);

Because the low bits have been masked away from offset and added to bytes,

> +
> +        /* if head and tail fall into the same alignment
> +         * we can omit the second read as it would read
> +         * the same block again */
> +        if ((offset + bytes) & (align - 1) &&

... the first part is just "bytes & (align - 1)"...

> +            offset / align == (offset + bytes) / align) {

... and the second part is just "bytes < align" (you can distribute
division over addition because offset / align has no reminder, and
simplify to "0 == bytes / align").

Putting it together, it becomes "bytes > 0 && bytes < align", or even
"bytes < align".

Thanks,

Paolo

> +            size_t tail_offs;
> +            tail_offs = (offset + bytes) & (align - 1);
> +            qemu_iovec_add(&local_qiov, head_buf + tail_offs,
> +                           align - tail_offs);
> +            bytes += align - tail_offs;
> +        }